Skip to content

Delete backend relocation modules and unify their behavior owners - #2665

Merged
1 commit merged into
mainfrom
slop/backend-relocations
Oct 23, 2026
Merged

1 commit merged into
mainfrom
slop/backend-relocations

Conversation

@trissim

@trissim trissim commented Oct 23, 2026

Copy link
Copy Markdown
Contributor

Remove the three relocation modules introduced by #2635 and put their behavior on the existing Thread, registry-privacy and Pi event owners. Deletes 296 lines and adds 198 (net -98).

  • ThreadRename, PlainRename and PrivateOwnerRename are deleted, including their privacy-to-handler map and registration hook. RegistryPrivacy.rename dispatches on the existing public/private owners; ThreadManagement applies the shared title, activity, runtime, ledger and catalog updates. The private owner retains the SQL/registry intent, compensation and completion behavior. RenameThreadResult lives beside its producing operation.
  • ThreadProvenance lives with Thread as its existing parent. Session-file, title, tags and backend registration metadata/defaults are inherited once; the repeated child declarations are deleted. Archived provenance still has no execution state. All Core consumers and test imports target the owner directly.
  • PiEvent owns both declaration registration and phase transition behavior. The forwarding-only PiTurnPhase parent is deleted. Existing MRO start precedence, end-event union and specialized compaction/tool hooks are retained. The two remaining derived phase maps are still tracked as unfinished roster work; moving them does not mark that phase complete.
  • Plan evidence and its counterexample fixtures follow the actual owners (RegistryPrivacy, PiEvent). No aliases or re-exports remain for the deleted modules.

Validation is assigned to the single integrator under Tristan's current order: no worker tests, debt scans or census runs. The attempted broad inventory was stopped without a completed current-head census; no global AST completeness or runtime equivalence claim is made. The migration used exact AST declaration spans for source edits and the source/import trace retained from the existing ownership work.

Integrator touched checks: tests/test_operations.py, tests/test_acp_private_nk_delivery.py, tests/test_importing.py, tests/test_historical_views.py, tests/test_pi_rpc_nominal.py, tests/test_phase_evidence.py, and tests/guards/test_source_proof_ownership.py. Integrate this head into the single integration branch; do not launch a separate worker suite.

Assumed: the integrator owns import/runtime and behavioral qualification at the combined head. No install or live verification is claimed.

Copilot AI balanced review requested due to automatic review settings October 23, 2026 07:54

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@trissim trissim closed this pull request by merging all changes into main in 27043e0 Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants