Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BusCapability represents partial record fields, but its append method assumed every capability had a sequence. Generated table annotations also discarded both sequence identity and the declared claim payload, forcing consumers to rely on attributes their contracts did not promise.
Move append_to to the existing complete BusRecord owner; BusRow.kind already requires that family. CapabilityRow owns the generated sequence field once, and every generated table inherits it. HeldResources reads through the existing Claimed projection and takes the sequence from its original claim transition. TypedTable select/stream overloads preserve the actual requested projection. Delete the redundant inner declared_fields cache; its two consumers already memoize their declaration-derived results.
The user-identity contention fixture now constructs its clients through Comms(root).messaging, supplying the existing goals owner instead of calling the obsolete constructor.
Validation:
This follows the integrated probe/cutover/completion/activity work from #2628 and CoordinatorRow checkpoint 7bd42ed (integrated as 8325507). Base is integration/installer-report-lifetime. Remaining hosted screening findings are being dispositioned against their actual source; they are not all demonstrated defects or claimed fixed by this PR.
Hosted finding dispositions (workflow 39894026668, candidate 13f9c35; not a fresh measurement):
All 98 hosted growth rows have individual status, owner and limits in the existing /home/ts/.cache/agent-scratch/mi-owner-withdrawal-trace.json under combined_owner_debt.hosted_dispositions. This preserves actual source judgments separately from unchecked screening leads. No local ratchet, full suite or new build was run.