Repository navigation
Conversation
…on' into fix/P421-owner-requests-unit-forks
|
debt-tools at 8d990c8, every finding: |
|
debt-src at 8d990c8, every finding: |
This was referenced Oct 23, 2026
Contributor
Author
|
Closing: this branch has no commit ahead of main, so it holds no work. Found by the fleet check 2026-10-23. Reopen if that is wrong. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner requests now have independent identities and lifetimes in the existing TodoStore. Orders bind one selected request; completing a request preserves other requests and the commander's execution goal. Connector directives carry selected request IDs on the committed message and use the existing committed-publication completion, including notification failure.
Ports the semantic delta of #2560 onto the current SQL bus. The port retains one indexed OwedAnswer read, exact answer references and UnitState ownership. GoalHistoryEntry inherits its public revision fields rather than redeclaring them. The installer carries legacy requests before BusHistory, including archived roots and existing catalogue seals; CarryChain derives this order from declaration-owned dependencies. This PR is stacked on #2616's branch for review of that delta alone.
The check exposed two additional defects. PiPayload ignored missing required fields and leaked SessionEntry constructor errors past Unreadable source handling; it now uses the existing FieldPlan rules. HumanSendRefusedError now retains the original typed cause, while programming failures propagate after rollback.
Validation at ca156d2:
Source evidence: NRA parsed 1,240 Core/tools/tests/Toad modules and built the 6,875-class family, with no parse omissions. Request state moved from Goal into OwnerRequest/TodoStore; task attachment and the existing publication origin own directive recording. The only retired RequestGoalOrder use is the isolated predecessor fixture executed under old source. Lexical/inheritance coverage does not prove dynamic binding or native/UI behavior. Detailed commands and before/after evidence are retained in the existing installer-fork integration evidence directory.
Integration obligations: combine CarryChain ordering with #2620, include Toad's migrated typed-cause call, rehearse the combined pair, and qualify the installed native/ACP/UI path with a fresh copied-agent DM, reply and tab return. No paired installation or live UI qualification claimed here.
ExternalBoundariesPhase's blanket regex remains unresolved: necessary all-failure committed-state preservation stays in Messaging and WAL retirement. RuntimeError-after-commit and simultaneous notification/completion failure controls remain intact. No ratchet exemption or phase-closure claim. #2469 remains a separate source-reviewed delta; its second review-status writer and retired bus reader must not be merged over current owners.