Skip to content

fix: prevent path traversal in websocket handle_data file reads #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
painbaba wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: prevent path traversal in websocket handle_data file reads #438

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions XAgentServer/application/websockets/common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,13 @@ def handle_data(row: Raw, root_dir: str):
file_name = output['file_name']
png_base64 = None
if file_name:
file_path = os.path.join(
root_dir, "workspace", file_name)
if os.path.exists(file_path):
# file_name comes from stored raws and is client-influenced:
# resolve it and never read outside the interaction workspace
workspace_dir = os.path.realpath(
os.path.join(root_dir, "workspace"))
file_path = os.path.realpath(
os.path.join(workspace_dir, file_name))
if file_path.startswith(workspace_dir + os.sep) and os.path.isfile(file_path):
try:
with open(file_path, "rb") as f:
png_base64 = base64.b64encode(
Expand Down