Skip to content

test(flow): compare exact contract digest for unset record.surface (#2133) #2150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yunusarda-sudo wants to merge 2 commits into
base: main
Choose a base branch
from
+40 −13
Open

test(flow): compare exact contract digest for unset record.surface (#2133) #2150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3d1dd46
test(flow): compare exact contract digest for unset record.surface (#…
yunusarda-sudo Nov 9, 2026
d20ee28
test(import-layers): rebaseline shifted debt rows in verify_run and q…
yunusarda-sudo Nov 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions packages/flow/import_layers_debt.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,9 +91,9 @@
{
"module": "openadapt_flow.verify_run",
"path": "packages/flow/openadapt_flow/verify_run.py",
"line": 719,
"line": 720,
"edge_kind": "direct",
"diagnostic": "openadapt_flow.verify_run:719: unresolvable dynamic import (nonliteral or unresolved import target)",
"diagnostic": "openadapt_flow.verify_run:720: unresolvable dynamic import (nonliteral or unresolved import target)",
"reason": "unbounded-config",
"follow_up": "unresolved-import-provider-migration",
"source_statement_sha256": "8c512ea9cf6f4dcfcb2dbb07904849468f9b705c898ff08ac216394b655eaf53"
Expand Down Expand Up @@ -151,9 +151,9 @@
{
"module": "openadapt_flow.qualification",
"path": "packages/flow/openadapt_flow/qualification.py",
"line": 2928,
"line": 3009,
"edge_kind": "transitive",
"diagnostic": "openadapt_flow.qualification:2928: unresolvable dynamic import (importer value escape)",
"diagnostic": "openadapt_flow.qualification:3009: unresolvable dynamic import (importer value escape)",
"reason": "vision-transfer",
"follow_up": "unresolved-import-provider-migration",
"source_statement_sha256": "817c0e8b4d2e627aa0d849e212b0788ac0e2ec16186e281f12e58fef134f0628"
Expand Down Expand Up @@ -291,9 +291,9 @@
{
"module": "openadapt_flow.verify_run",
"path": "packages/flow/openadapt_flow/verify_run.py",
"line": 719,
"line": 720,
"edge_kind": "transitive",
"diagnostic": "openadapt_flow.verify_run:719: unresolvable dynamic import (nonliteral or unresolved import target)",
"diagnostic": "openadapt_flow.verify_run:720: unresolvable dynamic import (nonliteral or unresolved import target)",
"reason": "unbounded-config",
"follow_up": "unresolved-import-provider-migration",
"source_statement_sha256": "8c512ea9cf6f4dcfcb2dbb07904849468f9b705c898ff08ac216394b655eaf53"
Expand Down
2 changes: 1 addition & 1 deletion packages/flow/tests/test_import_layers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2278,7 +2278,7 @@ def _dynamic_problems(graph: Graph, contract: dict, *, transitive: bool) -> list


DEBT_BASELINE_SHA256 = (
"6e21f87c00026e772d35ffb15a1e8837cd1a34152aeca0ec2b19fe4de8e6fa46"
"fce5e859344870a08b1bee158758e91869838852aa491c79b223fe67af7239a6"
)


Expand Down
39 changes: 33 additions & 6 deletions packages/flow/tests/test_record_surface.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,17 +78,44 @@ def test_a_stray_write_in_another_surface_refutes(tmp_path: Path) -> None:
assert _run(tmp_path, stray_note=True) == "reconciliation_required"


def test_an_unset_surface_keeps_the_contract_digest(tmp_path: Path) -> None:
from openadapt_flow.qualify.campaign import record_effects # noqa: F401
from openadapt_flow.verify_run import parse_verify_config as parse
def test_an_unset_surface_keeps_the_contract_digest() -> None:
from openadapt_flow.verify_run import (
parse_verify_config as parse,
)
from openadapt_flow.verify_run import (
verifier_identity,
verify_config_sha256,
)

single = {
without_field = {
"schema_version": "openadapt.verify/v1",
"verifier": {"kind": "sql", "sqlite_database": "x.db", "sql_query": "SELECT 1"},
"record": {"name": "p", "match": ["email"], "fields": {"email": "email"}},
}
effects = parse(single).effects
assert all("surface:" not in (e.probe or "") for e in effects)
with_none = {
"schema_version": "openadapt.verify/v1",
"verifier": {"kind": "sql", "sqlite_database": "x.db", "sql_query": "SELECT 1"},
"record": {
"name": "p",
"match": ["email"],
"fields": {"email": "email"},
"surface": None,
},
}

parsed_without = parse(without_field)
parsed_none = parse(with_none)

assert all("surface:" not in (e.probe or "") for e in parsed_without.effects)
assert all("surface:" not in (e.probe or "") for e in parsed_none.effects)

digest_without = verify_config_sha256(
verifier_identity(parsed_without.verifier), list(parsed_without.effects)
)
digest_none = verify_config_sha256(
verifier_identity(parsed_none.verifier), list(parsed_none.effects)
)
assert digest_without == digest_none


# -- a composite duplicate key read through a selected surface ---------------
Expand Down