Repository navigation
test(flow): compare exact contract digest for unset record.surface (#2133) - #2150
Open
yunusarda-sudo wants to merge 1 commit into
Open
yunusarda-sudo wants to merge 1 commit into
yunusarda-sudo wants to merge 1 commit into
Conversation
…penAdaptAI#2133) Signed-off-by: Yunus Ardaguney <yunusarda-sudo@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2133
Summary of Changes
Follow-up to the review of #1576:
test_an_unset_surface_keeps_the_contract_digestpreviously verified only that effect probes were unprefixed (assert all("surface:" not in (e.probe or "") for e in effects)), but did not test the PR's core invariant that an unsetrecord.surfaceleaves the contract digest unchanged.packages/flow/tests/test_record_surface.py):without_field(omittingrecord.surface) andwith_none(record.surface = None).verify_config_sha256(verifier_identity(parsed.verifier), list(parsed.effects))on both configurations and asserted that the computed contract digests are identical.Verification
PYTHONPATH=packages/flow uv run pytest packages/flow/tests/test_record_surface.py(10/10 passed).uv run ruff check packages/flow/tests/test_record_surface.py(clean).uv run ruff format --check packages/flow/tests/test_record_surface.py(clean).