Repository navigation
fix(kotlin-spring): omit @Pattern and @Size for URI values
#25752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
c19yamamoto
wants to merge
6
commits into
OpenAPITools:master
Choose a base branch
from
c19yamamoto:fix-size-annotation-generate-for-java-uri
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+173
−16
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
59d5a74
fix(kotlin-spring): omit @Size for URI model properties
c19yamamoto 23598f0
fix(kotlin-spring): preserve formatting when omitting URI @Size
c19yamamoto dfea6ab
fix: avoid no needs changes
c19yamamoto 7e22fd6
feat: omit pattern and add test
c19yamamoto 7289292
fix(kotlin-spring): omit validation constraints for URI parameters
c19yamamoto 805cef7
test(kotlin-spring): cover URI validation constraint branches
c19yamamoto File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 changes: 6 additions & 6 deletions
12
modules/openapi-generator/src/main/resources/kotlin-spring/beanValidationCore.mustache
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
modules/openapi-generator/src/test/resources/3_0/kotlin/uri-validation-pattern.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| openapi: 3.0.3 | ||
| info: | ||
| title: URI validation annotations | ||
| version: 1.0.0 | ||
| paths: | ||
| /uri-payload: | ||
| get: | ||
| operationId: getUriPayload | ||
| parameters: | ||
| - in: query | ||
| name: uriParam | ||
| schema: | ||
| type: string | ||
| format: uri | ||
| pattern: '^https?://' | ||
| minLength: 1 | ||
| - in: query | ||
| name: uriParamMaxLength | ||
| schema: | ||
| type: string | ||
| format: uri | ||
| maxLength: 10 | ||
| - in: query | ||
| name: uriParamMinMaxLength | ||
| schema: | ||
| type: string | ||
| format: uri | ||
| minLength: 2 | ||
| maxLength: 12 | ||
| - in: query | ||
| name: plainStringParam | ||
| schema: | ||
| type: string | ||
| pattern: '^[a-z]+$' | ||
| minLength: 1 | ||
| - in: query | ||
| name: plainStringParamMaxLength | ||
| schema: | ||
| type: string | ||
| maxLength: 10 | ||
| - in: query | ||
| name: plainStringParamMinMaxLength | ||
| schema: | ||
| type: string | ||
| minLength: 2 | ||
| maxLength: 12 | ||
| responses: | ||
| '200': | ||
| description: URI payload | ||
| content: | ||
| application/json: | ||
| schema: | ||
| $ref: '#/components/schemas/UriPayload' | ||
| components: | ||
| schemas: | ||
| UriPayload: | ||
| type: object | ||
| properties: | ||
| uri: | ||
| type: string | ||
| format: uri | ||
| pattern: '^https?://' | ||
| minLength: 1 | ||
| plainString: | ||
| type: string | ||
| pattern: '^[a-z]+$' | ||
| minLength: 1 | ||
| uriMaxLength: | ||
| type: string | ||
| format: uri | ||
| maxLength: 10 | ||
| uriMinMaxLength: | ||
| type: string | ||
| format: uri | ||
| minLength: 2 | ||
| maxLength: 12 | ||
| plainStringMaxLength: | ||
| type: string | ||
| maxLength: 10 | ||
| plainStringMinMaxLength: | ||
| type: string | ||
| minLength: 2 | ||
| maxLength: 12 |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.