Repository navigation
fix(kotlin-spring): omit @Pattern and @Size for URI values - #25752
Open
c19yamamoto wants to merge 6 commits into
Open
c19yamamoto wants to merge 6 commits into
c19yamamoto wants to merge 6 commits into
Conversation
@Size for URI model properties
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
@Size for URI model properties@Pattern and @Size for URI properties
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
@Pattern and @Size for URI properties@Pattern and @Size for URI values
c19yamamoto
marked this pull request as draft
November 19, 2026 10:21
c19yamamoto
marked this pull request as ready for review
November 19, 2026 10:21
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
c19yamamoto
marked this pull request as draft
November 19, 2026 11:03
c19yamamoto
marked this pull request as ready for review
November 19, 2026 11:03
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25751
The Kotlin Spring generator emits
@Patternor@Sizefor URI model properties and operation parameters when the correspondingpattern,minLength, ormaxLengthconstraint is set. These values are generated asjava.net.URI, which is not supported by Bean Validation's@Patternor@Sizeconstraints and can cause validation failures.This change omits string-based
@Patternand@Sizeannotations for URI model properties and parameters. The generator also marks URI parameters accordingly so the parameter validation template can apply the same guards. Constraints on regular string values and collection sizes remain unchanged.Similar Java generator fix: #18095, #18135
Kotlin technical committee: @karismann @Zomzog @andrewemery @4brunu @stefankoppier @e5l @AndreyVMarkelov
Verification
KotlinSpringServerCodegenTest#uriPropertiesAndParametersDoNotGetPatternOrSizeConstraints— passed (1 test, 0 failures). It coversminLengthonly,maxLengthonly, and both length constraints for URI model properties and query parameters, while confirming regular strings retain the matching@Sizeconstraints../mvnw clean package, full sample generation, and documentation export passed before the AI review follow-ups. The focused test above passed after the latest changes.PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples, as manually written tests may be removed.
Summary by cubic
Fixes #25751. The Kotlin Spring generator now omits
@Patternand@Sizeconstraints onformat: uriproperties and parameters, which are generated asjava.net.URIand aren't supported by Bean Validation's@Patternand@Sizeannotations, so previously generated code was invalid.Adds
isUriguards to the pattern and string-length branches inbeanValidationCore.mustacheandbeanValidationModel.mustache, backed by a regression test coveringminLength,maxLength, and both variants. Regular string properties and collection size constraints are unaffected, and URI parameters are marked viaupdateParameterForString.Written for commit 805cef7. Summary will update on new commits.