Repository navigation
docs: add dataset-label draft examples - #14
Conversation
NingyuSUN
left a comment
There was a problem hiding this comment.
Thanks for #7 — nicely done.
Verified: both drafts match the dataset-label profile (predicate has_label, sample → class_label, required curated_label + sample_link); reference_annotation is admitted and training_data is rejected with BEV010 for missing human acceptance — exactly the boundary the issue asked to show. The workflow and test glob change (*claim.yaml) is necessary and minimal, and those were the only two globs over examples/drafts/. The smoke test covers both new drafts. CI passes on all jobs.
One small change before merging: CHANGELOG placement. 0.7.0 was released after you opened this and its "Unreleased" section became "0.7.0", so your line would land inside the published 0.7.0 section without any conflict. Please move it under the new ## Unreleased heading at the top of CHANGELOG.md (added in #16).
Happy to merge once that's in.
5d785be to
b119150
Compare
|
Thanks for the review, @NingyuSUN! I have moved the Validated locally with:
|
What and why
Closes #7
Adds two synthetic
dataset-labeldraft examples so users can start from the compact draft format instead of a full record:dataset_label_reference.yamlcontains the requiredcurated_labelandsample_linkevidence forreference_annotationand is admitted.dataset_label_training_unreviewed.yamlcontains the same evidence fortraining_databut deliberately has no human acceptance, so it is rejected withBEV010.Each draft header includes the build/validate commands and expected exit code. The draft test suite pins both outcomes and validates both examples against the generated
dataset-labeldraft schema. The installed-wheel smoke check now builds and validates the examples too.Admission boundary
No validation rule changes. This adds examples that exercise the existing
dataset-labeladmission boundary: reference annotation does not require human acceptance, while training data does.Checklist
uv run --frozen ruff check .,uv run --frozen mypyanduv run --frozen pytest --covpassCHANGELOG.mdupdated if users will noticeFull repository CI is left to the upstream pull-request checks.