Skip to content

fix: bump libredfish to v0.44.19#3442

Merged
williampnvidia merged 1 commit into
NVIDIA:mainfrom
williampnvidia:william/bump-libredfish-v0.44.19
Jul 13, 2026
Merged

fix: bump libredfish to v0.44.19#3442
williampnvidia merged 1 commit into
NVIDIA:mainfrom
williampnvidia:william/bump-libredfish-v0.44.19

Conversation

@williampnvidia

Copy link
Copy Markdown
Contributor

Summary

  • bump libredfish from v0.44.18 to v0.44.19
  • include Dell HTTP boot-option compatibility for both the legacy exact display name and the suffix added by newer firmware

Upstream fix: NVIDIA/libredfish#102
Issue: NVIDIA/libredfish#101

Testing

  • cargo metadata --locked --no-deps --format-version 1
  • cargo check --locked -p carbide-redfish
  • cargo check --locked -p carbide-redfish -p carbide-machine-controller -p carbide-api-core (Linux)
  • cargo make --no-workspace clippy-flow (Linux)

Signed-off-by: Josh P <williamp@nvidia.com>
@williampnvidia williampnvidia requested a review from a team as a code owner July 13, 2026 19:02
@coderabbitai

coderabbitai Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 6c15c5c0-de6d-40c7-b888-110fb36eeaa4

📥 Commits

Reviewing files that changed from the base of the PR and between e80faf8 and 56e2007.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • Cargo.toml

Summary by CodeRabbit

  • Chores
    • Updated an internal dependency to a newer version, with no user-visible feature or behavior changes.

Walkthrough

The workspace updates its libredfish dependency from git tag v0.44.18 to v0.44.19.

Changes

Workspace dependency update

Layer / File(s) Summary
Update libredfish release tag
Cargo.toml
Changes the workspace libredfish dependency tag from v0.44.18 to v0.44.19.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: upgrading libredfish to v0.44.19.
Description check ✅ Passed The description is clearly related and matches the version bump and compatibility update in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@williampnvidia williampnvidia requested a review from poroh July 13, 2026 19:05
@williampnvidia williampnvidia self-assigned this Jul 13, 2026
@williampnvidia williampnvidia added this to the v2.0 milestone Jul 13, 2026
@github-actions

Copy link
Copy Markdown

🔍 Container Scan Summary

Service Total Critical High Medium Low Other
boot-artifacts-aarch64 3 0 0 3 0 0
boot-artifacts-x86_64 3 0 0 3 0 0
forge-admin-cli-x86_64 255 13 30 79 7 126
machine-validation-runner 800 40 234 292 36 198
machine_validation 800 40 234 292 36 198
machine_validation-aarch64 800 40 234 292 36 198
nvmetal-carbide 800 40 234 292 36 198
TOTAL 3461 173 966 1253 151 918

Per-CVE detail lives in the per-service grype-* artifacts (JSON + SARIF). Severity counts only — no CVE IDs published here.

@williampnvidia williampnvidia merged commit bec9dfe into NVIDIA:main Jul 13, 2026
59 checks passed
nv-dmendoza pushed a commit that referenced this pull request Jul 13, 2026
Backport of #3442 to `release/v2.0`.

Newer Dell firmware appends interface details to HTTP boot-option
display
names. libredfish v0.44.19 preserves the legacy exact-name match while
also accepting the suffix used by newer firmware, allowing SetBootOrder
to work with both firmware generations.

`release/v2.0` previously pinned libredfish v0.44.16, so this backport
advances it directly to v0.44.19. This also includes the changes from
v0.44.17 and v0.44.18. Because v0.44.18 introduced
`RedfishVendor::VeraRubin`, this PR also cherry-picks the compatibility
handling from #3074 required to keep the release branch compiling.

## Related issues

- Mainline dependency PR: #3442
- VeraRubin compatibility PR: #3074
- libredfish fix: NVIDIA/libredfish#102
- libredfish issue: NVIDIA/libredfish#101

## Type of Change

- [ ] **Add** - New feature or capability
- [ ] **Change** - Changes in existing functionality
- [x] **Fix** - Bug fixes
- [ ] **Remove** - Removed features or deprecated functionality
- [ ] **Internal** - Internal changes (refactoring, tests, docs, etc.)

## Breaking Changes

- [ ] **This PR contains breaking changes**

## Testing

- [x] Unit tests added/updated in the upstream libredfish fix
- [ ] Integration tests added/updated
- [ ] Manual testing performed
- [ ] No testing required

Validated on Linux against this backport branch:

- `cargo check --locked -p carbide-redfish -p carbide-site-explorer`
- focused Clippy for `carbide-redfish` and `carbide-site-explorer`
- `cargo make --no-workspace clippy-flow`

## Additional Notes

This PR contains two backported mainline commits:

- `bec9dfe7c` — bump libredfish to v0.44.19
- `366947aef` — handle the VeraRubin vendor variant introduced by
v0.44.18

Release Management should perform the merge.

---------

Signed-off-by: Josh P <williamp@nvidia.com>
Co-authored-by: hakhondzadeh <hakhondzadeh@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Verify

Development

Successfully merging this pull request may close these issues.

2 participants