fix(v2.0): support extended Dell HTTP boot option names#3451
Conversation
- bump libredfish from v0.44.18 to v0.44.19 - include Dell HTTP boot-option compatibility for both the legacy exact display name and the suffix added by newer firmware Upstream fix: NVIDIA/libredfish#102 Issue: NVIDIA/libredfish#101 - `cargo metadata --locked --no-deps --format-version 1` - `cargo check --locked -p carbide-redfish` - `cargo check --locked -p carbide-redfish -p carbide-machine-controller -p carbide-api-core` (Linux) - `cargo make --no-workspace clippy-flow` (Linux) Signed-off-by: Josh P <williamp@nvidia.com> (cherry picked from commit bec9dfe)
fix: Add RedfishVendor::VeraRubin to be compatible with libredfish changes. Bump up the libredfish version Vera Rubin compute tray ingestion. (cherry picked from commit 366947a) Signed-off-by: Josh P <williamp@nvidia.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
williampnvidia
requested review from
nv-dmendoza and
treyd
and removed request for
treyd
🔐 TruffleHog Secret Scan✅ No secrets or credentials found! Your code has been scanned for 700+ types of secrets and credentials. All clear! 🎉 🕐 Last updated: 2026-07-13 21:32:38 UTC | Commit: e800a42 |
🔍 Container Scan Summary
Per-CVE detail lives in the per-service |
nv-dmendoza
left a comment
nv-dmendoza
left a comment
There was a problem hiding this comment.
LGTM, backports for VR fixes
4 participants
Backport of #3442 to
release/v2.0.Newer Dell firmware appends interface details to HTTP boot-option display
names. libredfish v0.44.19 preserves the legacy exact-name match while
also accepting the suffix used by newer firmware, allowing SetBootOrder
to work with both firmware generations.
release/v2.0previously pinned libredfish v0.44.16, so this backportadvances it directly to v0.44.19. This also includes the changes from
v0.44.17 and v0.44.18. Because v0.44.18 introduced
RedfishVendor::VeraRubin, this PR also cherry-picks the compatibilityhandling from #3074 required to keep the release branch compiling.
Related issues
Type of Change
Breaking Changes
Testing
Validated on Linux against this backport branch:
cargo check --locked -p carbide-redfish -p carbide-site-explorercarbide-redfishandcarbide-site-explorercargo make --no-workspace clippy-flowAdditional Notes
This PR contains two backported mainline commits:
bec9dfe7c— bump libredfish to v0.44.19366947aef— handle the VeraRubin vendor variant introduced by v0.44.18Release Management should perform the merge.