Repository navigation
ci: check private base access before allocation - #1642
Merged
yifeif-nv merged 1 commit intoOct 9, 2026
Merged
Conversation
Signed-off-by: yifeif <277870278+yifeif-nv@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
5 of 11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Dev runs #1558 and #1581 reached healthy AWS and Nebius instances, then failed private-base metadata access before any PR entry point ran. Both instances were confirmed deleted. The access error hid the HTTP status, and a missing coordinator summary was published as a generic test failure.
Exit Criteria
Implementation
The existing shared-base preflight now checks package access as well as token identity. HTTP failures retain their status and bounded, recognized scope/SSO/restriction indicators; network failures remain distinct.
For
dependency-image-access-checkon the shared base, a separate trusted step checks the dedicated reader against the same protected reference. It independently checks package metadata and a pinned registry manifest, so a metadata API failure does not hide whether registry reads work. Existing anonymous/public-token denial checks remain separate. The diagnostic allocates no VM and executes no image.The owner validates family result evidence and exports an explicit failure class. The final Dev publisher uses
errorfor infrastructure failures andfailurefor validated post-entry PR failures; unconfirmed cleanup remains pending. A missing receipt cannot produce a successful complete result.Validation
git diff --check: passed.Notes For Future Readers
This change targets
ci/developer. It changes neither model passing criteria nor retry counts. HTTP status and recognized indicators narrow the diagnosis; they do not by themselves prove a package ACL or token-scope defect. Shared-base runtime and GPU qualification remain separate evidence.