Repository navigation
Conversation
Expose Qwen generation through the semantic TextContinuation contract while retaining the existing graph, sampler, native-KV and distributed paths. Move family support and qualification manifests to the new task, and add config and SDK consumer coverage. Rebuilt bundles are required for the new primary task.
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
I, JiaxinD <djx2048@gmail.com>, hereby add my Signed-off-by to this commit: 130e2cc Cover the semantic primary Task across all declared Qwen model types. Signed-off-by: JiaxinD <djx2048@gmail.com>
Signed-off-by: JiaxinD <djx2048@gmail.com>
Signed-off-by: JiaxinD <djx2048@gmail.com>
Signed-off-by: JiaxinD <djx2048@gmail.com>
Accept the pinned 4B and 8B sentence-transformers configurations while preserving unknown-topology rejection. Add optional native E2E cases and compare embedding dimensions against the reference configuration. Signed-off-by: JiaxinD <djx2048@gmail.com>
|
@yifeif-nv Could you rerun Dev Community CI for #1558 ( |
Hey, I've triggered the internal CI for you. The dev CI is the community GPU CI that is still in development. It is not gating the merging. So once the internal CI is passed, I will merge the PR. Thanks. |
|
@yifeif-nv Thanks for triggering Internal CI. It failed on |
Preserve upstream streaming, cancellation, generation leases and KV-capacity checks while retaining semantic Task configuration and bounded token-ID inputs. Keep ChatML system prompts, zero-token continuations and family SDK consumer build dependencies, with native contract coverage. Signed-off-by: JiaxinD <djx2048@gmail.com>
Signed-off-by: JiaxinD <djx2048@gmail.com>
|
Hey @JiaxinD I think we'll need to remove for this PR. Then you can locally verify it via This is due to the private CI require any ckpt declared to be tested in L0 and both ckpt are current declared as premerge = false. We can add in the test in a later time |
Merge NVIDIA/main while preserving semantic continuation and S1 Mini ownership. Remove the unqualified larger embedding manifests requested by the maintainer, retain their CPU contracts, and propagate system prompts unchanged through text SDK checks. Signed-off-by: JiaxinD <djx2048@gmail.com>
|
Removed the 4B/8B manifests and integrated upstream at cb6291bb. CPU profile coverage remains; 170 Python tests and seven native contracts passed locally. |
Signed-off-by: JiaxinD <djx2048@gmail.com>
|
@yifeif-nv Community CPU, Stable and Dev pass on |
Signed-off-by: JiaxinD <djx2048@gmail.com>
|
@yifeif-nv Community CPU, Stable and Dev passed for 1404788. Please trigger protected CI for this head. |
Integrate current upstream conversation history with the family-owned continuation configuration and retain separate template and token-cap constraints. Signed-off-by: JiaxinD <djx2048@gmail.com>
|
Integrated upstream conversation history in 31f1b53, retaining the family-owned Config and streaming lease. Seven native CPU contracts and 118 Python tests passed; GPU/protected qualification remains pending. |
|
@yifeif-nv Community CPU passed for 31f1b53. Please trigger protected CI for this head. |
Background
Qwen needs semantic
TextContinuationsupport in #1498 while preserving streaming and generation capacity. Its embedding comparator also hardcodes the 0.6B output dimension. The integration retains upstream's native conversation history support.Exit Criteria
Expose typed text/token-ID continuation, preserve streaming and conversation behavior, validate published embedding profiles and reject invalid inputs. Larger embedding execution remains outside this PR's qualification matrix.
Implementation
text_generation; pass system prompts unchanged to text SDK consumers while token-ID inputs bypass preprocessing.Changes remain under
families/qwen. Rebuild legacy generation bundles for the semantic primary task. Shared API/ABI definitions and bundle format are unchanged by this PR. The upstream merge preserves published history.Change categories
Validation
Commands and Results
pytest families/qwen/tests core/builder/tests/test_model_support.py -qgit diff --checkConversation tests verify binding/schema, exact once-only history rendering and pre-engine rejection boundaries. CPU engine/state doubles do not establish generated output correctness.
Hardware, Environment, and Revisions
Head
31f1b53d30a5afc315f0d0ceda2de8a9b78a071bintegrates NVIDIA/main8194f406fb0f3b89d81d719566852e71f1a34f16into prior head1404788d78fddc82adebe58dc9090fb6e4aa6185. Windows Python3.13 CPU, WSL Ubuntu GCC13.3, C11/C++17 and CUDA12.6 headers/runtime;CUDA_VISIBLE_DEVICESempty. Pinned fixtures:Qwen/Qwen3-Embedding-4B@5cf2132abc99cad020ac570b19d031efec650f2bandQwen/Qwen3-Embedding-8B@1d8ad4ca9b3dd8059ad90a75d4983776a23d44af.Not Run / Remaining Gaps
Current-head TensorRT/GPU inference, protected CI, larger embeddings, FP8/TP4 and performance are unvalidated. Radix authentication expired. Earlier head
1404788dpassed public CPU/Stable/Dev; those results do not qualify this merge. Fifteen Python skips are unselected GPU E2Es; one Windows native build probe is skipped, with native CMake validation separately completed in WSL.Contributor Self-Review
Reviewed provenance/task boundaries, conversation integration, configuration, streaming lifecycle and consumers.
Notes For Future Readers
S1 Mini criteria and checkpoint pins are preserved. Removed manifests can return after qualification. Ready conversion remains subject to the three-PR author capacity policy; protected execution remains required.
Risk level
Primary-task and streaming integration need protected execution; CPU tests do not establish GPU parity or performance equivalence.