Repository navigation
perf(llama): reduce build host-memory retention #1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JiaxinD
wants to merge
8
commits into
NVIDIA:main
Choose a base branch
from
JiaxinD:perf/llama-plan-lifetime
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+404
−2
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
2ed6621
perf(llama): release prefill plan before decode build
JiaxinD f993c11
perf(llama): release projection scratch between loads
JiaxinD 00e8143
Merge remote-tracking branch 'upstream/main' into perf/llama-plan-lif…
JiaxinD b2f1dc3
perf(llama): release embedding scratch before layers
JiaxinD 1154d0a
fix(llama): resolve staged E2E checkpoints offline
JiaxinD 2df0010
chore(llama): integrate upstream Edge builder
JiaxinD aa9cc85
merge(llama): preserve quantized weight loading
JiaxinD d9ef21e
perf(llama): avoid tied-head input copy
JiaxinD File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| # SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| """Exercise staged checkpoint lookup without Hub metadata or network access.""" | ||
|
|
||
| import pytest | ||
| from huggingface_hub import constants | ||
| from huggingface_hub.errors import LocalEntryNotFoundError | ||
|
|
||
| from .test_e2e import _checkpoint | ||
|
|
||
|
|
||
| @pytest.fixture | ||
| def offline_cache(tmp_path, monkeypatch): | ||
| monkeypatch.setattr(constants, "HF_HUB_CACHE", str(tmp_path)) | ||
| monkeypatch.setattr(constants, "HF_HUB_OFFLINE", True) | ||
| return tmp_path | ||
|
|
||
|
|
||
| def test_pinned_checkpoint_uses_snapshot_without_cached_tree(offline_cache): | ||
| revision = "a" * 40 | ||
| snapshot = offline_cache / "models--trtmc-test--llama" / "snapshots" / revision | ||
| snapshot.mkdir(parents=True) | ||
| (snapshot / "config.json").write_text("{}", encoding="utf-8") | ||
|
|
||
| assert _checkpoint({"hf_id": "trtmc-test/llama", "hf_revision": revision}) == snapshot | ||
|
|
||
|
|
||
| def test_missing_checkpoint_is_not_replaced_by_another_revision(offline_cache): | ||
| cached = offline_cache / "models--trtmc-test--llama" / "snapshots" / ("a" * 40) | ||
| cached.mkdir(parents=True) | ||
| (cached / "config.json").write_text("{}", encoding="utf-8") | ||
|
|
||
| with pytest.raises(LocalEntryNotFoundError): | ||
| _checkpoint({"hf_id": "trtmc-test/llama", "hf_revision": "b" * 40}) | ||
|
|
||
|
|
||
| def test_staged_snapshot_still_requires_config(offline_cache): | ||
| revision = "a" * 40 | ||
| snapshot = offline_cache / "models--trtmc-test--llama" / "snapshots" / revision | ||
| snapshot.mkdir(parents=True) | ||
|
|
||
| with pytest.raises(AssertionError): | ||
| _checkpoint({"hf_id": "trtmc-test/llama", "hf_revision": revision}) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.