fix(helm): support OIDC authentication-only mode - #3180
Closed
guanchzhou wants to merge 1 commit into
Closed
Conversation
Render explicit empty roles for authentication-only mode and reject partial RBAC role pairs before deploying an invalid gateway configuration. Signed-off-by: Andrey Maltsev <maltsev.andrey@gmail.com>
guanchzhou
requested review from
a team,
derekwaynecarr,
mrunalp and
sjenning
as code owners
September 4, 2026 08:40
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. |
Author
|
recheck |
Author
|
Closing in favor of #1871, which already covers this chart behavior and gates authentication-only mode behind an explicit server.auth.allowOidcAuthOnly opt-in. This PR rendered empty roles unconditionally, so authentication-only mode would activate silently whenever both roles were left empty. That is the posture #1871 deliberately rejects, and it also carries the matching server-side validation that this change does not touch. Landing this first would work against that design. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make the chart's documented OIDC authentication-only mode effective by rendering explicit empty role values, while rejecting partial role pairs before deployment.
Related Issue
Fixes #3045
Related Work
#1871 includes this Helm behavior within a broader authentication-posture change and is currently blocked by merge conflicts. This PR stays narrowly scoped to the reported chart bug.
Changes
admin_roleanduser_rolewhenever OIDC is enabled so empty values override gateway defaultsTesting
mise run pre-commitpasseshelm unittest deploy/helm/openshell(123 tests)helm unittest deploy/helm/openshell-workspace(4 tests)Checklist