Skip to content

Report: BV-BRC-only evidence is not available, not zero, on sequence-only runs (#90) - #101

Merged
Jiahuic merged 2 commits into
mainfrom
feat/90-not-available
Nov 15, 2026
Merged

Jiahuic merged 2 commits into
mainfrom
feat/90-not-available

Conversation

@Jiahuic

@Jiahuic Jiahuic commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Merge order: after #98 → #99 → #100, using a merge commit (not squash or rebase). Base is main; until the earlier PRs merge, this diff also shows their changes.

Part of #90 and #87.

On the FASTA route four score components (virulence_amr, drug_target, essential, human_homolog_penalty) have no possible source but scored 0, exactly like "checked and false" (pitfall #12).

  • s2f/m2_triage/availability.py: M2 writes annotation_route and not_available (component → reason) to m2_pdb/run.json. A provider that ran (--human-homology, --essentiality) clears its component.
  • The runner reports these as not available, not as "BV-BRC precomputed rows only" (which was wrong on this route).
  • The full report header shows a "Not available on this run" note listing inputs and components.

Live run output:

virulence_amr (weight +0.20) not available: no BV-BRC genome on the fasta route
essential (weight +0.15) not available: no BV-BRC genome on the fasta route; pass --essentiality

Not done from #90's scope: a per-protein evidence-coverage line in the HTML. The note is run-level, which covers this case because on the FASTA route every protein lacks the same sources. Leaving #90 open for that.

Tests: 6 new (tests/test_not_available.py), 442 total.

🤖 Generated with Claude Code

…only runs (#90)

On the --from-fasta route there is no BV-BRC genome, so four score
components (virulence_amr, drug_target, essential, human_homolog_penalty)
had no possible source but scored 0 like "checked and false". M2 now
records them under not_available in m2_pdb/run.json (with the route),
the runner reports them as not available instead of claiming BV-BRC
rows were used, and the full report shows a not-available note in its
header. A provider that ran (--human-homology, --essentiality) clears
its component.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Jiahuic
Jiahuic merged commit 7a0ecbb into main Nov 15, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant