Repository navigation
Report: BV-BRC-only evidence is not available, not zero, on sequence-only runs (#90) - #101
Merged
Merged
Conversation
…only runs (#90) On the --from-fasta route there is no BV-BRC genome, so four score components (virulence_amr, drug_target, essential, human_homolog_penalty) had no possible source but scored 0 like "checked and false". M2 now records them under not_available in m2_pdb/run.json (with the route), the runner reports them as not available instead of claiming BV-BRC rows were used, and the full report shows a not-available note in its header. A provider that ran (--human-homology, --essentiality) clears its component. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order: after #98 → #99 → #100, using a merge commit (not squash or rebase). Base is
main; until the earlier PRs merge, this diff also shows their changes.Part of #90 and #87.
On the FASTA route four score components (
virulence_amr,drug_target,essential,human_homolog_penalty) have no possible source but scored 0, exactly like "checked and false" (pitfall #12).s2f/m2_triage/availability.py: M2 writesannotation_routeandnot_available(component → reason) tom2_pdb/run.json. A provider that ran (--human-homology,--essentiality) clears its component.Live run output:
Not done from #90's scope: a per-protein evidence-coverage line in the HTML. The note is run-level, which covers this case because on the FASTA route every protein lacks the same sources. Leaving #90 open for that.
Tests: 6 new (
tests/test_not_available.py), 442 total.🤖 Generated with Claude Code