Repository navigation
M2: scoring profiles — the triage policy becomes a choice (#93) - #102
Merged
Merged
Conversation
WEIGHTS encodes an antibacterial target-selection policy, wrong for viral proteins, single hypotheticals or human targets, and not portable between bacterial genomes either (#61). The weights are now a named profile (bacterial-target, the unchanged default; evidence-only, provisional) or a JSON file naming every component. run.json records the profile and its weights, and python -m s2f.m2_triage.rescore re-ranks recorded proteins.tsv under another profile with no re-querying, reproducing M2 exactly under the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge order: after #98 → #99 → #100 → #101, using a merge commit (not squash or rebase). Base is
main; until the earlier PRs merge, this diff also shows their changes.Part of #93 and #87.
WEIGHTSencodes an antibacterial target-selection policy. That is wrong for viral proteins, single hypotheticals or human targets, and the weights do not transfer between bacterial genomes either: G37 and HS11286 put 32 and 10 hypotheticals in the top 50 under identical weights (#61).What changes
s2f/m2_triage/profiles.py):bacterial-targetis the default and is exactly today'sWEIGHTS, so no ranking changes.evidence-onlyuses structural evidence alone, with no penalties and no human-homolog disqualification. It is provisional and uncalibrated.--weights FILE: the JSON must name every component, so a typo cannot silently drop one to 0.run.jsonstores theprofileand its weights, and each protein'sweights_versionreads<profile>@<version>.python -m s2f.m2_triage.rescore --run runs/<id> --profile evidence-onlywritesm2_pdb/rescored/<profile>.tsvand leaves the run's own ranking untouched.--profileand--weights. Docs are indocs/02a-m2-pdb-evidence.mdunder "Scoring profiles".Verified
proteins.tsvpredates three components (surface_bonus,ligandable_homolog,membrane_penalty), and the tool refuses them rather than guessing zeros. They need a fresh M2 run to compare profiles.Not done from #93
Tests: 10 new (
tests/test_m2_profiles.py), 452 total.🤖 Generated with Claude Code