Skip to content

馃悰 expose conversation ID to browser clients #3752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ump45nose wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

馃悰 expose conversation ID to browser clients #3752

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/apps/app_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ def create_app(
allow_credentials=True,
allow_methods=cors_methods or ["*"],
allow_headers=["*"],
expose_headers=["conversation_id"],
)

# Register exception handlers
Expand Down
1 change: 1 addition & 0 deletions test/backend/app/test_config_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ def test_config_app_default_cors_config(self):
assert cors_middleware.kwargs.get("allow_credentials") is True
assert cors_middleware.kwargs.get("allow_methods") == ["*"]
assert cors_middleware.kwargs.get("allow_headers") == ["*"]
assert cors_middleware.kwargs.get("expose_headers") == ["conversation_id"]


class TestConfigAppRouterConfiguration:
Expand Down
1 change: 1 addition & 0 deletions test/backend/app/test_northbound_base_app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,6 +316,7 @@ def test_cors_middleware_configuration(self):
self.assertTrue(cors_middleware.kwargs.get("allow_credentials"))
self.assertEqual(cors_middleware.kwargs.get("allow_methods"), ["GET", "POST", "PUT", "DELETE"])
self.assertEqual(cors_middleware.kwargs.get("allow_headers"), ["*"])
self.assertEqual(cors_middleware.kwargs.get("expose_headers"), ["conversation_id"])

def test_router_inclusion(self):
"""The main northbound router should be included."""
Expand Down