Skip to content

🐛 expose conversation ID to browser clients - #3752

Open
ump45nose wants to merge 1 commit into
ModelEngine-Group:developfrom
ump45nose:fix/expose-conversation-id-cors-3610
Open

🐛 expose conversation ID to browser clients#3752
ump45nose wants to merge 1 commit into
ModelEngine-Group:developfrom
ump45nose:fix/expose-conversation-id-cors-3610

Conversation

@ump45nose

Copy link
Copy Markdown

Summary

  • expose the existing conversation_id response header through CORS
  • cover the shared app factory and northbound app middleware configuration

Why

The agent endpoints already return conversation_id, but browser clients cannot read non-safelisted response headers unless Access-Control-Expose-Headers includes it. Static frontends therefore lose the ID even though it is present on the HTTP response.

Fixes #3610.

Tests

  • FastAPI TestClient CORS smoke with an Origin request and conversation_id: 42
  • python3 -m py_compile backend/apps/app_factory.py test/backend/app/test_config_app.py test/backend/app/test_northbound_base_app.py
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant