Skip to content

Reuse one HTTP client for OpenSandbox calls #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaladDay merged 1 commit into from
Nov 7, 2026
Merged

Reuse one HTTP client for OpenSandbox calls #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions services/core/internal/sandbox/opensandbox/provider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,10 +64,13 @@ func newProvider(c sandbox.DirectConfig) (*Provider, error) {
return nil, errors.New("OpenSandbox deployment configuration is unavailable")
}
scheme, _, _ := strings.Cut(deployment.APIURL, "://")
// Every call reaches the same server, so one transport keeps its connections
// alive; without it the SDK builds a new transport per connected sandbox.
client := &http.Client{Transport: osdk.DefaultTransport()}
return &Provider{
installation: c.InstallationID, image: deployment.Image, resources: c.Selection.Resources,
connection: osdk.ConnectionConfig{Domain: deployment.APIURL, Protocol: scheme, APIKey: deployment.APIKey, UseServerProxy: true},
lifecycle: osdk.NewLifecycleClient(deployment.APIURL+"/"+osdk.APIVersion, deployment.APIKey),
connection: osdk.ConnectionConfig{Domain: deployment.APIURL, Protocol: scheme, APIKey: deployment.APIKey, UseServerProxy: true, HTTPClient: client},
lifecycle: osdk.NewLifecycleClient(deployment.APIURL+"/"+osdk.APIVersion, deployment.APIKey, osdk.WithHTTPClient(client)),
resolve: func(ctx context.Context, host string) ([]netip.Addr, error) {
return net.DefaultResolver.LookupNetIP(ctx, "ip", host)
},
Expand Down
Loading