Repository navigation
Reuse one HTTP client for OpenSandbox calls - #939
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The OpenSandbox SDK builds a new
http.Transportfor the lifecycle client and another for the execd client on everyConnectSandbox. That means every Observe, Create and RunCommand opens new TCP connections, and the idle ones stay in the discarded transports for 30 s. The adapter now builds one client and passes it to both theConnectionConfigand the lifecycle client, so every call to the server shares one transport. Timeouts are unchanged: the SDK still applies its 30-second request timeout to its own copy of the client.Measurement
Fifty Observe + RunCommand pairs against the package's fake OpenSandbox server, three runs each, all identical:
The measurement test was temporary and is not committed.
Verification
make check-sandbox-provider-contractpasses.Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.