Skip to content

Record that reviewer denials carry no rationale #938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SaladDay merged 1 commit into from
Nov 7, 2026
Merged

Record that reviewer denials carry no rationale #938

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion contracts/agents-api/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ Each item is Core's deliberate or native behavior where the official service beh
- An empty or blank `agent.model` returns 400 at Session create and update; the pinned schema allows it.
- Codex maps programmatic tool calling to its native `code_mode`, whose model-written scripts call the other tools; the feature is under development upstream.
- Codex rejects programmatic tool calling together with `multi_agent`.
- Codex `review: auto_review` reviews only the actions Codex escalates, such as a forced `rm` or an MCP tool call that needs approval; Codex has full filesystem access inside the sandbox, so other commands and file edits run without review. Its native reviewer calls the model `codex-auto-review` through the Session's model provider, and a provider that does not serve it denies every escalated action with its own error.
- Codex `review: auto_review` reviews only the actions Codex escalates, such as a forced `rm` or an MCP tool call that needs approval; Codex has full filesystem access inside the sandbox, so other commands and file edits run without review. Its native reviewer calls the model `codex-auto-review` through the Session's model provider, and a provider that does not serve it denies every escalated action with its own error. A denied action's Item reads `failed` without the reviewer's rationale, because the pinned Items have no field for it.
- Codex runs without its native goals (`create_goal`, `get_goal` and `update_goal`), because an active goal starts turns of its own after the Turn ends ([Codex Runtime](https://github.com/MiniMax-AI/OpenAgentCore/blob/main/services/core/deploy/codex/README.md)).
- A Session's `agent.tools` omits `tool_search` declarations.
- Core rejects an inline `authorization` on a Session MCP transport, an `Authorization` entry in `headers` and a nonempty stdio `env`: credentials come only from Vaults (`credential_id`) and environment values only from the Environment (`env_vars`) ([MCP](./execution-tools.md#mcp)).
Expand Down
4 changes: 2 additions & 2 deletions contracts/agents-api/zh/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: "OpenAI 兼容性"
source: contracts/agents-api/index.md
source_hash: daa785e87ebf76a48a1ec28194e333c64343771bd6d32060a3f8bce127e973db
source_hash: 999a54f6ce39363218b3ec312cec6180b15a6659292be41c03a15a03ece56dd0
---

Core 实现下方固定版本的 OpenAI Agents API。本台账列出各项资源的覆盖情况、相对于官方服务的所有差异以及已知缺口。
Expand Down Expand Up @@ -97,7 +97,7 @@ Core 自身字段位于 `x_agents_core` 中（[Core extensions](../../../docs/zh
- `agent.model` 为空或只含空白时，Session 创建和更新返回 400；固定版本 schema 允许这样的值。
- Codex 把程序化工具调用映射到原生 `code_mode`，由模型编写的脚本调用其他工具；该功能在上游仍处于开发中。
- Codex 拒绝同时使用程序化工具调用和 `multi_agent`。
- Codex 的 `review: auto_review` 只审查 Codex 自己升级的操作，例如强制 `rm` 或需要审批的 MCP 工具调用；Codex 在沙箱内拥有完整的文件系统权限，其他命令和文件修改不经审查。其原生 reviewer 通过 Session 的模型提供方调用 `codex-auto-review` 模型，不提供该模型的提供方会以自己的错误拒绝每个升级的操作。
- Codex 的 `review: auto_review` 只审查 Codex 自己升级的操作，例如强制 `rm` 或需要审批的 MCP 工具调用；Codex 在沙箱内拥有完整的文件系统权限，其他命令和文件修改不经审查。其原生 reviewer 通过 Session 的模型提供方调用 `codex-auto-review` 模型，不提供该模型的提供方会以自己的错误拒绝每个升级的操作。被拒绝操作的 Item 为 `failed`，不带 reviewer 的理由，因为固定版本的 Item 没有对应字段。
- Codex 不启用原生 goals（`create_goal`、`get_goal` 和 `update_goal`），因为处于活动状态的 goal 会在 Turn 结束后自行启动新的 turn（[Codex Runtime](https://github.com/MiniMax-AI/OpenAgentCore/blob/main/services/core/deploy/codex/README.md)）。
- Session 的 `agent.tools` 会省略 `tool_search` 声明。
- Core 拒绝 Session MCP 传输中的内联 `authorization`、`headers` 中的 `Authorization` 条目以及非空的 stdio `env`：凭据只来自 Vault（`credential_id`），环境值只来自 Environment（`env_vars`）（[MCP](execution-tools.md#mcp)）。
Expand Down
Loading