Repository navigation
Research: take Linux and Windows ONNX Runtime from NuGet - #1657
Merged
Merged
Conversation
The GitHub repository these providers downloaded release archives from returns 404, so every fresh Linux or Windows provision fails before a build or test starts. Both providers now extract the library from Microsoft's official Microsoft.ML.OnnxRuntime NuGet package for the same version. The libraries in that package are byte-identical to the ones in the release archives, so the existing library pins are unchanged and still decide whether a build proceeds. The package itself gets its own pin, which replaces the three archive pins nothing reads any more. macOS is unchanged and still downloads from GitHub. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linux and Windows builds of Research now get ONNX Runtime from Microsoft's official NuGet package instead of a GitHub release archive. The library pins do not change.
Why
github.com/microsoft/onnxruntimeand its release downloads return 404 (still the case on November 19, 2026). The desktop providers download a release archive on every fresh checkout, so each of these fails before it builds or tests anything:research-rust, on any pull request that touchesapps/maple-research/frontend/src-tauri/masterhas stayed green only because no run since then selected one of those lanes.Change
provide-linux-onnxruntime.shandprovide-windows-onnxruntime.shdownloadMicrosoft.ML.OnnxRuntime1.23.2 from nuget.org (published October 25, 2025), check it against a new package pin, and extract the one library they need to the path it had before. The existing check of that library against its own pin is untouched, so a different binary still fails the build.The libraries in the package are byte-identical to the ones the release archives carried:
libonnxruntime.so13ab8084…74c68blibonnxruntime.so648ffa64…44c286onnxruntime.dlldec964ab…84f1eaThe three archive pins are removed because nothing reads them now. The extracted folder holds only the library; the headers, CMake files and import library from the archives were never used, since the desktop build loads ONNX Runtime at run time.
The package is 118 MB, larger than the archives it replaces. A fresh provision took under two seconds on a fast connection.
Not in this change
Checked
Not checked: the Windows provider under Git Bash on Windows. That lane runs only with the
ci:packagelabel, which would also run the macOS desktop lane, and that one still fails at its download.🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.