Repository navigation
Research: take macOS ONNX Runtime from NuGet - #1658
Merged
Merged
Conversation
The macOS provider still downloaded a release archive from a GitHub repository that returns 404, so a fresh macOS checkout could not build or run Research's checks. It now extracts the x86_64 and arm64 libraries from the same NuGet package the Linux and Windows providers use and joins them with lipo. Each has the code-directory hash of the matching half of the universal library pinned until now, and a valid Microsoft Developer ID signature. Microsoft signed them separately from that universal library, though, so the file hashes are new: the provider pins the two files and checks the joined library one architecture at a time. A library from the old release archive fails that check once and is fetched again. The package helper now extracts several libraries from one download. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1657, which moved the Linux and Windows providers to Microsoft's NuGet package. This does the same for macOS, the last desktop provider that still downloaded from the GitHub repository that returns 404. Until this lands a fresh macOS checkout cannot build Research or run its Rust checks.
Why this one changes a pin
On Linux and Windows the NuGet libraries are byte-identical to the ones we pinned, so #1657 changed no library pin. macOS is different. The release archive carried one universal library; NuGet carries one library per architecture, and Microsoft signed those separately. The code is the same, the signatures are not, so the old pin can never match.
What was compared, against the universal library pinned until now:
d2231eaa…c64ed1, samed73b7d4b…81c108, sameChange
provide-macos-onnxruntime.shextracts both libraries from the NuGet package, checks each against a new pin, and joins them withlipoat the path the bundle already reads.lipolays out the file.Checked
This pull request carries the
ci:packagelabel so the macOS, Linux and Windows desktop lanes run. That is also the first run of the Windows provider on Windows since #1657.Still open: iOS builds ONNX Runtime from source out of the same repository and works only while its cached build is available.
🤖 Generated with Claude Code
Open in [code]smith · Need help on this PR? Tag
@codesmith-botwith what you need.