Repository navigation
Move react-vectorstyle out, as the js-vectorstyle submodule - #31
Merged
Merged
Conversation
The package has no React dependency, so it becomes @mapconductor/js-vectorstyle in its own repository (MapConductor/js-vectorstyle, split from here with its history) and returns as a submodule. - workspaces, build:packages / dev:packages, the API gate: the new name - react-vectortile and examples/basic depend on and import the new name - scripts/fetch-vector-assets.mjs fetches only the renderer now; the package fetches its own style compiler, from the same pinned release - package-lock.json regenerated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-vectorstylehas no React dependency (only js-sdk-core), so it becomes@mapconductor/js-vectorstylein its own repository, MapConductor/js-vectorstyle, split from here with its history, and comes back as a submodule.build:packages/dev:packagesand the API gate use the new name@mapconductor/js-vectorstylescripts/fetch-vector-assets.mjsnow fetches only the renderer; js-vectorstyle fetches its own style compiler, from the same pinned release (v0.1.0)package-lock.jsonregeneratedIn the new repository the package's test is now under version control. Here it was ignored by the
*.mjsrule in.gitignore, so CI ran 0 tests for it; it now runs 16.@mapconductor/react-vectorstylewas never published to npm, so nothing needs deprecating.