Repository navigation
Move react-vectortile out, as a submodule - #34
Merged
Merged
Conversation
It goes to its own repository (MapConductor/react-vectortile, split from here with its history) and returns as a submodule, like js-vectorstyle. - scripts/fetch-vector-assets.mjs and scripts/vector-assets.json move into the package, which fetches its own renderer from the same pinned release; nothing else here used them - .gitignore: the package ignores its own vendor/
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
react-vectortile goes to its own repository, MapConductor/react-vectortile, split from here with its history (18 commits). It returns as a submodule, the same way js-vectorstyle did in #31.
scripts/fetch-vector-assets.mjsandscripts/vector-assets.jsonmove into the package. It now fetches its own renderer from the same pinned release (v0.1.0, same SHA-256). Nothing else in react-sdk used them..gitignore: thereact-vectortile/vendor/entry is removed, because the package now ignores its ownvendor/.package-lock.jsonis unchanged.Checked locally:
npm install, the builds of js-sdk-core, js-sdk-react, js-vectorstyle and react-vectortile,node scripts/api-surface.mjs check, and the examples/basic build.