Repository navigation
Pass labelPosition through the React Native bridge - #3
Merged
Merged
Conversation
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
React Native のブリッジで、既定アイコンの
labelPositionをネイティブへ渡すようにしました。markerIconToNativeがlabelPositionを送ります。ReactNativeImageDefaultIconにもこのオプションを追加しました。colorDefaultのinfoAnchorが、ビットマップ基準に変換済みの値のまま送られていました。ネイティブ側でもう一度変換されるので、二重変換になっていました。指定された元の値(requestedInfoAnchor)を送るよう直しています。NativeMarkerCodec.ktと iOS のNativeMapCodec.swiftで、labelPositionを読むようにしました。InfoBubbleLayer.nativeの位置計算を、アイコンの実寸(markerIconExtentPx)で行うようにしました。依存
確認
:mapconductor_js-sdk-react)のコンパイルと、iOS 側(MapConductorReactNativeCore)のビルドが通りました。mainは develop の js-sdk-core に無いMapViewStyleを使っていて、develop のコアに対してはビルドできません(既存の状態です)。