Repository navigation
Pick the marker drawn under the tap, label included - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
タップしたときに「指の下に描かれているマーカー」を選ぶようにしました。コアの
MarkerHitTest.pick(@_spi(MapConductorDriver))を使っています。これまでは、「先端が最寄りの 1 つ」を矩形判定するか、許容範囲に入った候補のうちアンカーが一番近いものを選んでいました。そのため、隣のピンの頭や横に置いたラベルのタップが外れていました。
なお、SPI を使うため、該当ファイルの import を
@_spi(MapConductorDriver) import MapConductorCoreに変えています。依存
確認(develop 上)
maps-core/djinniのパッケージ解決が通らず、develop 上でのビルドは確認できていません。代わりに、同じ差分を当てた作業ブランチで、サンプルアプリ全体(このプロバイダを含む)のビルドが通ることを確かめました。