Skip to content

PR67 CI — type-safe ambient namespace check #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LogicDuke merged 1 commit into from
Sep 2, 2026
Merged

PR67 CI — type-safe ambient namespace check #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/cockpit-host/support/d3-network-policy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,8 +374,8 @@ export function valueSymbolOf(checker: ts.TypeChecker, node: ts.Node): ts.Symbol
return checker.getSymbolAtLocation(node);
}

/** Whether a declaration is ambient: it or an enclosing declaration carries `declare`. */
function isAmbient(node: ts.Declaration): boolean {
/** Whether a node is ambient: it or an enclosing declaration carries `declare`. */
function isAmbient(node: ts.Node): boolean {
let current: ts.Node = node;
while (!ts.isSourceFile(current)) {
if (ts.canHaveModifiers(current) && (ts.getCombinedModifierFlags(current as ts.Declaration) & ts.ModifierFlags.Ambient) !== 0) {
Expand Down Expand Up @@ -440,7 +440,7 @@ function isInstantiatedNamespace(declaration: ts.ModuleDeclaration): boolean {
if (ts.isModuleDeclaration(declaration.body)) return isInstantiatedNamespace(declaration.body);
if (!ts.isModuleBlock(declaration.body)) return false;
return declaration.body.statements.some((statement) => {
if (isAmbient(statement as ts.Declaration)) return false;
if (isAmbient(statement)) return false;
if (ts.isVariableStatement(statement) || ts.isClassDeclaration(statement)) return true;
if (ts.isFunctionDeclaration(statement)) return statement.body !== undefined;
if (ts.isEnumDeclaration(statement)) return (ts.getCombinedModifierFlags(statement) & ts.ModifierFlags.Const) === 0;
Expand Down
Loading