PR67 CI — type-safe ambient namespace check - #68
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Swish! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Stacked child of PR #67 (
rebuild/d3-clean-network-policy, exact parent head5ac18be70be10d40ca4610b3bc826e81335e0435). Child head:7f8f4119739adcbdb1d5800a82c7374b0269a6fd.Fixes the exact-head CI failure of PR #67 only:
TS2352intests/cockpit-host/support/d3-network-policy.ts(443,19)(Conversion of type 'Statement' to type 'Declaration').Change
One changed file:
tests/cockpit-host/support/d3-network-policy.ts(+3 / −3).isAmbientparameter widened fromts.Declarationtots.Node(the function only ever walked its argument as ats.Node).statement as ts.Declarationcast inisInstantiatedNamespaceis replaced bystatement.Semantic behavior is preserved: the runtime-shadow probes (instantiated namespace
fetch/WebSocket, runtimeimport = require, exported runtime import alias) remain ALLOW; ambient, type-only namespace, type-only import-equals and private type-alias namespace controls remain DENY. No other D3 logic changed.Local validation
typecheck, focused D3 tests (438 passed), purity (319 passed / 8 skipped), lint, build and
git diff --checkall green locally.Review status
Codex independently reviewed the repair substantially before its workspace credits were exhausted. The Commander explicitly waived only the unfinished final Codex POST/verdict formatting; all other gates remain in force.
This PR must remain DRAFT pending exact-head CI.
🤖 Generated with Claude Code
https://claude.ai/code/session_01JPfL76suEiud2qfmrgUURL