Skip to content

refactor: share preview-loop skip and drop unused trial ask prop - #4904

Merged
tyler-dane merged 2 commits into
mainfrom
refactor/simplify-recent-merges
Oct 28, 2026
Merged

tyler-dane merged 2 commits into
mainfrom
refactor/simplify-recent-merges

Conversation

@cursor

@cursor cursor Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

What and why

Nightly simplify of merges after #4866. Preview-loop pause, dedupe, and stale retirement share one queued-row skip, and the next monthly start reuses the completion helper instead of a December wrap. TrialStartAsk drops the unused priceLineContext leftover from the charge-date copy change. Description list toggle runs through one helper. Cancel reason tabindex and payload are flattened. Celebration trial copy reads BILLING_PLAN.TRIAL_LENGTH_DAYS instead of a hardcoded 7.

Verify

VERDICT: PASS
Checks run: test:web, test:backend:fast, type-check, lint, knip, test:a11y, test:e2e
test:web 733 passed; test:a11y 67 passed; test:e2e 301 passed, 3 skipped.

Open in Web View Automation 

Note

Low Risk
Mostly structural refactors in preview-loop scheduling and UI copy; email scheduling behavior is covered by existing schedule tests and skip reasons are unchanged.

Overview
Consolidates welcome email preview-loop maintenance: queued rows are skipped through one skipPreviewLoopQueuedRows path (monthly pause, duplicate-generation dedupe, stale step-list retirement), and new generations enqueue via enqueuePreviewLoopAtMonthlyStart. nextPreviewLoopMonthlyStart now reuses nextPreviewLoopMonthlyStartAfterCompletion instead of hand-rolled month/December logic.

On the calendar web side, TrialStartAsk drops the unused priceLineContext prop (including Settings). Checkout celebration trial copy uses BILLING_PLAN.TRIAL_LENGTH_DAYS instead of a hardcoded 7. Cancel subscription reason submission and radio tabIndex are simplified without changing the optional-details rules. Description editor list toggling shares a small runListToggle helper for the initial attempt and retry.

Reviewed by Cursor Bugbot for commit 971db4b. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-authored-by: tyler <tyler@switchback.tech>
@tyler-dane tyler-dane added the agent-automerge Agent-loop finished; merge-guard may squash-merge label Oct 28, 2026 — with Cursor
@tyler-dane
tyler-dane marked this pull request as ready for review October 28, 2026 01:20
@tyler-dane
tyler-dane enabled auto-merge October 28, 2026 01:20
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
@github-actions

Copy link
Copy Markdown
Contributor

Boot bundle: 530.6 KB gzip (+0.0 KB vs main)

@tyler-dane
tyler-dane added this pull request to the merge queue Oct 28, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 28, 2026
@tyler-dane
tyler-dane added this pull request to the merge queue Oct 28, 2026
Merged via the queue into main with commit 5c832bd Oct 28, 2026
32 checks passed
@tyler-dane
tyler-dane deleted the refactor/simplify-recent-merges branch October 28, 2026 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-automerge Agent-loop finished; merge-guard may squash-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants