Repository navigation
refactor: share preview-loop skip and drop unused trial ask prop - #4904
Merged
Merged
Conversation
Co-authored-by: tyler <tyler@switchback.tech>
tyler-dane
marked this pull request as ready for review
October 28, 2026 01:20
tyler-dane
enabled auto-merge
October 28, 2026 01:20
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Contributor
|
Boot bundle: 530.6 KB gzip (+0.0 KB vs main) |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Nightly simplify of merges after #4866. Preview-loop pause, dedupe, and stale retirement share one queued-row skip, and the next monthly start reuses the completion helper instead of a December wrap. TrialStartAsk drops the unused
priceLineContextleftover from the charge-date copy change. Description list toggle runs through one helper. Cancel reason tabindex and payload are flattened. Celebration trial copy readsBILLING_PLAN.TRIAL_LENGTH_DAYSinstead of a hardcoded 7.Verify
VERDICT: PASS
Checks run: test:web, test:backend:fast, type-check, lint, knip, test:a11y, test:e2e
test:web 733 passed; test:a11y 67 passed; test:e2e 301 passed, 3 skipped.
Note
Low Risk
Mostly structural refactors in preview-loop scheduling and UI copy; email scheduling behavior is covered by existing schedule tests and skip reasons are unchanged.
Overview
Consolidates welcome email preview-loop maintenance: queued rows are skipped through one
skipPreviewLoopQueuedRowspath (monthly pause, duplicate-generation dedupe, stale step-list retirement), and new generations enqueue viaenqueuePreviewLoopAtMonthlyStart.nextPreviewLoopMonthlyStartnow reusesnextPreviewLoopMonthlyStartAfterCompletioninstead of hand-rolled month/December logic.On the calendar web side,
TrialStartAskdrops the unusedpriceLineContextprop (including Settings). Checkout celebration trial copy usesBILLING_PLAN.TRIAL_LENGTH_DAYSinstead of a hardcoded 7. Cancel subscription reason submission and radiotabIndexare simplified without changing the optional-details rules. Description editor list toggling shares a smallrunListTogglehelper for the initial attempt and retry.Reviewed by Cursor Bugbot for commit 971db4b. Bugbot is set up for automated code reviews on this repo. Configure here.