Repository navigation
refactor: share event form focus pulse and drop unused date state - #4927
Merged
Merged
Conversation
Collapse per-field macOS focus counters into one request so repeated shortcuts restore without adding a new property each time. Drop unused date-field grid-focus React state and share the date picker month jump. Co-authored-by: tyler <tyler@switchback.tech>
tyler-dane
marked this pull request as ready for review
October 29, 2026 01:25
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 29, 2026 01:25
Contributor
|
Boot bundle: 530.9 KB gzip (+0.0 KB vs main) |
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Nightly simplify of merges after #4904. Location, guests, RSVP, recurrence, calendar, and actions no longer each own a focus-request counter. One
eventFormFocusRequestpulse restores a repeated shortcut, and the common SwiftUI restore path isonEventFormFocusRequest. RSVP still updates its tab-stop locally before the async restore. EventFormDateField drops unused grid-focus React state (the ref already drove keyboard routing). DatePicker's today control and month-chord handler share onejumpToThisMonthclosure. PostHog identity and session controllers sharePostHogAnalyticsIds.makeLowercasedUUID.Verify
VERDICT: PASS
Checks run: test:web, type-check, lint, knip, test:a11y, test:e2e
test:web passed; test:a11y 67 passed; test:e2e 303 passed, 3 skipped.
Swift package and AppKit builds remain CI-only on this machine (test-macos.yml).
Note
Low Risk
Refactors and deduplication with existing tests updated; keyboard focus and analytics behavior should be unchanged aside from the intended repeated-shortcut fix on macOS.
Overview
macOS event form keyboard focus replaces six per-field focus counters with one
eventFormFocusRequestpulse on everyfocusEventFormField, so repeating the same shortcut still re-applies focus. Form sections (attendees, location, recurrence, actions) use the sharedonEventFormFocusRequestSwiftUI helper; calendar menu and RSVP listen to the same counter (RSVP still sets tab-stop synchronously before the async focus restore).PostHog (macOS) centralizes lowercased UUID generation in
PostHogAnalyticsIds.makeLowercasedUUIDfor identity and session controllers.Web
DatePickerfactors a singlejumpToThisMonthclosure for the “go to this month” button and month keyboard chords.EventFormDateFielddrops redundant grid-focus React state (the ref already drives keyboard routing) and tightens the keyboard-selected-day DOM query.Reviewed by Cursor Bugbot for commit 52d0cd5. Bugbot is set up for automated code reviews on this repo. Configure here.