Repository navigation
refactor: share session flags, synthetic account check, and logout write timeout - #4866
Merged
Merged
Conversation
…ite timeout Deduplicate recent OAuth and email dispatch scaffolding, and make the logout pending-write wait honor its timeout when a mutation never settles. Co-authored-by: tyler <tyler@switchback.tech>
tyler-dane
added
the
agent-automerge
Cursor
tyler-dane
enabled auto-merge
October 27, 2026 01:34
Contributor
|
Boot bundle: 528.8 KB gzip (+0.0 KB vs main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Nightly simplification of merges after #4835, focused on the largest recent churn: Google signup scopes recovery (#4852), logout write flush (#4859), and synthetic journey email skip (#4849).
isSyntheticAccountpredicate (no local email wrapper)waitForPendingEventMutationsnow races the deadline so a hung mutation cannot block logout foreverBehavior is unchanged for successful paths. Hung logout writes now proceed after 15s, which is the timeout the helper already documented.
Verify
VERDICT: PASSChecks run:
test:web(selected files + full suite via verify)test:backend:fasttype-checklintkniptest:a11y(67 passed)test:e2e(297 passed, 3 skipped on isolated retry after a resource-contended verify run)A first
bun run verify --strictwasINCOMPLETEuntil Chromium was installed. After install, selected non-Playwright checks passed; a11y passed; an in-verify e2e wave failed without a usable log (sandbox output truncated). Isolatedbun run test:e2ethen passed. Diff does not touch those e2e specs.