Repository navigation
refactor: collapse leftover date-field, trial-lock, and oauth helpers - #4762
Merged
Merged
Conversation
Co-authored-by: tyler <tyler@switchback.tech>
tyler-dane
marked this pull request as ready for review
October 23, 2026 01:33
tyler-dane
enabled auto-merge
October 23, 2026 01:33
Contributor
|
Boot bundle: 512.9 KB gzip (+0.0 KB vs main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
What and why
Nightly simplification of merges after #4711. Date-field key membership lives in one util, the unreachable Mod+Enter commit path is gone, unused checkout Back variants are gone,
awaiting_checkoutwrite-lock checks share one helper (andbilling-write-guardfolds intotrial-step-request), signup-trial browser Back no longer duplicates dismiss, sync connect callbacks importOAUTH_CALLBACK_EVENT, the /meet noscript CTA usesmeetingSetupRootHref, timezone hydrate reuses storage refresh, and day-column pinned ids share one empty set. No product behavior change.Verify
VERDICT: PASSfor selected local checks:test:sync:fast,test:web,test:booking-web,type-check,lint,knip,test:a11y.test:e2eran 288 passed. Two flakes in untouchede2e/timed/shift-hold-event-hints.spec.ts(tap f shows day-prefix jump keys...andlowercase day prefix plus digit...) failed as focus-poll timeouts under parallel load and each passed on isolated retry (3.5s and 4.4s). The diff does not touch event-jump or that spec. Sandbox Playwright flake, not a local blocker; CI decides.Note
Low Risk
Mostly module moves and dead-code removal; the signup-trial Back and date-field keyboard tweaks are small surface-area changes but stay within existing billing and form flows.
Overview
This PR is a cleanup pass across booking, billing, event-form keyboard handling, timezone hydration, and sync analytics—intended to deduplicate helpers without changing product behavior.
Billing / trial gating:
awaiting_checkoutwrite-lock checks are centralized inisAwaitingCheckoutWriteLocked().blockAwaitingCheckoutEventWritemoves from deletedbilling-write-guardintotrial-step-request(call sites likeuseEventMutationsimport from there). Embedded checkout drops unused Back props (backVariant, shortcut hints) and always renders a single secondary Back button.Event form dates: Key classification (
isEventFormDateFieldClosedKey/isEventFormDateCalendarKey) lives in the keys util; the field component drops inline guards and the Mod+Enter commit branch.calendarActionis exhaustive (nonull).Other:
/meetstatic HTML noscript CTA usesmeetingSetupRootHref()like the React landing. Signup-trial browser Back always dismisses the step (OAuth callback pathname branch removed). Timezone hydrate reusesrefreshPinnedFromStorage(). Day view columns share one empty pinned-calendar set. Sync OAuth callbacks import sharedOAUTH_CALLBACK_EVENTfrom core analytics.Reviewed by Cursor Bugbot for commit a96ed74. Bugbot is set up for automated code reviews on this repo. Configure here.