Skip to content

refactor: collapse leftover date-field, trial-lock, and oauth helpers - #4762

Merged
tyler-dane merged 1 commit into
mainfrom
cursor/code-simplification-6b1d
Oct 23, 2026
Merged

tyler-dane merged 1 commit into
mainfrom
cursor/code-simplification-6b1d

Conversation

@cursor

@cursor cursor Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #

What and why

Nightly simplification of merges after #4711. Date-field key membership lives in one util, the unreachable Mod+Enter commit path is gone, unused checkout Back variants are gone, awaiting_checkout write-lock checks share one helper (and billing-write-guard folds into trial-step-request), signup-trial browser Back no longer duplicates dismiss, sync connect callbacks import OAUTH_CALLBACK_EVENT, the /meet noscript CTA uses meetingSetupRootHref, timezone hydrate reuses storage refresh, and day-column pinned ids share one empty set. No product behavior change.

Verify

VERDICT: PASS for selected local checks: test:sync:fast, test:web, test:booking-web, type-check, lint, knip, test:a11y.

test:e2e ran 288 passed. Two flakes in untouched e2e/timed/shift-hold-event-hints.spec.ts (tap f shows day-prefix jump keys... and lowercase day prefix plus digit...) failed as focus-poll timeouts under parallel load and each passed on isolated retry (3.5s and 4.4s). The diff does not touch event-jump or that spec. Sandbox Playwright flake, not a local blocker; CI decides.

Open in Web View Automation 

Note

Low Risk
Mostly module moves and dead-code removal; the signup-trial Back and date-field keyboard tweaks are small surface-area changes but stay within existing billing and form flows.

Overview
This PR is a cleanup pass across booking, billing, event-form keyboard handling, timezone hydration, and sync analytics—intended to deduplicate helpers without changing product behavior.

Billing / trial gating: awaiting_checkout write-lock checks are centralized in isAwaitingCheckoutWriteLocked(). blockAwaitingCheckoutEventWrite moves from deleted billing-write-guard into trial-step-request (call sites like useEventMutations import from there). Embedded checkout drops unused Back props (backVariant, shortcut hints) and always renders a single secondary Back button.

Event form dates: Key classification (isEventFormDateFieldClosedKey / isEventFormDateCalendarKey) lives in the keys util; the field component drops inline guards and the Mod+Enter commit branch. calendarAction is exhaustive (no null).

Other: /meet static HTML noscript CTA uses meetingSetupRootHref() like the React landing. Signup-trial browser Back always dismisses the step (OAuth callback pathname branch removed). Timezone hydrate reuses refreshPinnedFromStorage(). Day view columns share one empty pinned-calendar set. Sync OAuth callbacks import shared OAUTH_CALLBACK_EVENT from core analytics.

Reviewed by Cursor Bugbot for commit a96ed74. Bugbot is set up for automated code reviews on this repo. Configure here.

@tyler-dane
tyler-dane marked this pull request as ready for review October 23, 2026 01:33
@tyler-dane tyler-dane added the agent-automerge Agent-loop finished; merge-guard may squash-merge label Oct 23, 2026
@tyler-dane
tyler-dane enabled auto-merge October 23, 2026 01:33
@github-actions

Copy link
Copy Markdown
Contributor

Boot bundle: 512.9 KB gzip (+0.0 KB vs main)

@tyler-dane
tyler-dane added this pull request to the merge queue Oct 23, 2026
Merged via the queue into main with commit faa4283 Oct 23, 2026
37 checks passed
@tyler-dane
tyler-dane deleted the cursor/code-simplification-6b1d branch October 23, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-automerge Agent-loop finished; merge-guard may squash-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants