Repository navigation
refactor: collapse event-form visibility and oauth-callback leftovers - #4711
Merged
Merged
Conversation
#4678 added a visibility input, then EventForm kept recomputing the same calendar, busy, and read-only flags beside it. One draft calendar helper feeds both, and the form reads those flags from the input. Co-authored-by: tyler <tyler@switchback.tech>
#4679 listed edit-jump-field-digit as a palette action, then the palette always filtered it out. macOS never included it. The list is now only invocable rows, and the cmd store resets between tests. Co-authored-by: tyler <tyler@switchback.tech>
#4673 parsed the same callback query string in two modules. One oauthCallbackSearchParams helper now owns the leading-? strip. Co-authored-by: tyler <tyler@switchback.tech>
tyler-dane
marked this pull request as ready for review
October 22, 2026 01:31
tyler-dane
enabled auto-merge
October 22, 2026 01:31
Contributor
|
Boot bundle: 510.3 KB gzip (+0.0 KB vs main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No issue: found by the nightly tech-debt sweep over merges after #4659/#4669 (#4673 through #4702).
What and why
Three behavior-preserving cleanups of repetition this week's event-form and OAuth work grew. None changes a public contract.
refactor(web): share event-form visibility calendar lookup and flags#4678 added
eventFormFieldVisibilityInputFromDraft, then EventForm kept a second nested calendar lookup and recomputed busy / read-only / schedule-locked / conference kind beside it. OnecalendarFromDrafthelper now feeds both, and the form reads those flags from the input. The grid hook also stopped memoizing unused digit/letter tables and resolves visibility once per key handler.refactor(core): drop dead jump-field row from event-form palette list#4679 listed
edit-jump-field-digitas a command-palette action, then the palette always filtered it out. macOS never included it. The list is now only invocable rows. The cmd store from the same PR is registered in the test reset registry so handlers cannot leak across files.refactor(web): parse oauth callback search in one helper#4673 parsed the same callback query string in
strip-oauth-callback-urlandresolve-stale-provider-oauth-replay. OneoauthCallbackSearchParamshelper owns the leading-?strip.Verify
bun run verify --strictselectedcore, web.Checks run:
test:core,test:web,type-check,lint,knip,test:a11y,test:e2e.test:a11y65 passedtest:e2e276 passedNote
Low Risk
Refactors duplicate logic and test isolation without changing auth or save flows; palette list only drops an entry that was never shown.
Overview
Behavior-preserving refactors that dedupe recent event-form and OAuth callback code.
Event form visibility: Adds shared helpers (
calendarFromDraft,calendarFields,peopleFromDetails) so draft→visibility input andEventFormuse one calendar lookup and the same busy/read-only/schedule-locked/conference flags fromfieldVisibilityInputinstead of recomputing them.useActiveEventFormFieldVisibilitynow only exposesresolveVisibilityInput; grid edit-sequence shortcuts resolve letter fields on demand viaactiveEditSequence().Command palette: Removes non-invocable
edit-jump-field-digitfromlistEventFormActions(palette had been filtering it anyway) and drops the palette-side filter. ExportsinitialEventFormCmdStateand resetsuseEventFormCmdStorein the test store registry so handlers do not leak across tests.OAuth: Centralizes callback query parsing in
oauthCallbackSearchParams(leading-?handling) for stale-replay resolution and param detection tests.Reviewed by Cursor Bugbot for commit 30bbe89. Bugbot is set up for automated code reviews on this repo. Configure here.