Repository navigation
refactor: share google rate-limit reasons and description-link helpers - #4659
Merged
Merged
Conversation
Co-authored-by: tyler <tyler@switchback.tech>
tyler-dane
marked this pull request as ready for review
October 21, 2026 01:21
tyler-dane
enabled auto-merge
October 21, 2026 01:21
Contributor
|
Boot bundle: 509.4 KB gzip (+0.0 KB vs main) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Nightly cleanup of merges after #4617, focused on #4646 (Google 400s / write classification), #4645 (description link UX), #4635 (provider save failures), and #4613/#4638 (sidebar footer).
Writer and People share
hasGoogleRateLimitReasoninstead of private quota lists.googleErrorReasonsis derived fromgoogleErrorEntries. Description-link shortening shares one prefix and punctuation helper.useDescriptionLinkPresentationdrops unusedenabledand a dead focus ref. Mod+click opens description links throughfindLinkElement/openDescriptionLink. Mutation toast provider lookup usescalendarIdFromMutationInput. macOS shortcut footer reuseshideTipsButton.Left alone: AuthStore success paths, Welcome Enter vs connect-prompt Enter, first-event celebration, TimePicker commit-draft event, TimePicker shortcut test harness, calendar notice stack, TimeGrid hit-test passes, ShiftHintOverlay, TimePickers start/end menu booleans, NativeGridKeyboardRouter confirmation-dialog and guest-email Return handling, deploy yaml awk readers, EventFormDateField commit paths, recurrence timezone vs draft TZ, keyboard vs form duplicate pipelines, CompassKit test trees, CommandPaletteSearch adapter, palette recent-while-searching, Event form Meet
draft.kind === "create"type narrowing, SidebarActions footer icons, CommandPalettePhosphorIcon maps, DST wall-clock vs elapsed minutes.Verify
VERDICT: PASSChecks run:
test:sync:fast,test:web,type-check,lint,knip,test:a11y,test:e2e.CI-only:
test:macos/test:macos:packages(no Xcode on this machine).Note
Medium Risk
Google write and contact-search retry classification changes behavior when quota reasons appear only on the error object; description link presentation now applies whenever the editor exists, not gated by a removed flag.
Overview
Consolidates Google API error handling so quota/rate-limit reasons live in
GOOGLE_RATE_LIMIT_REASONSandhasGoogleRateLimitReason, withgoogleErrorReasonsbuilt fromgoogleErrorEntries. The event writer and People contact search drop local 403 quota lists and use the shared helper (including reasons on the error object, not only the response body). Read-path transients still includebackendError/internalError; writes only treat quota-style 403s as retryable.Description editor link UX is tightened: autolink shortening recognizes
www.labels, Mod+click opens links viafindLinkElement/openDescriptionLink, anduseDescriptionLinkPresentationalways runs when the editor is mounted (removed unusedenabledflag and dead focus ref).Event mutation error toasts resolve provider via new
calendarIdFromMutationInputinstead of inlined input parsing. macOS shortcut footer reuses a sharedhideTipsButtonin the event-form tip.Reviewed by Cursor Bugbot for commit dbb46db. Bugbot is set up for automated code reviews on this repo. Configure here.