Repository navigation
fix(macos): real window title-bar screenshot and validation - #4651
Closed
tyler-dane wants to merge 2 commits into
Closed
tyler-dane wants to merge 2 commits into
tyler-dane wants to merge 2 commits into
Conversation
Drop content compositing; crop XCUITest window screenshots only. Validate traffic lights, June nav text band, and reject footer/grid crops. Group sidebar footer icons on the leading edge per web #4638. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 20, 2026 22:04
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
github-merge-queue
Bot
removed this pull request from the merge queue due to a manual request
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4331
Summary
Removes the content-view compositing path that produced a bottom-of-window crop (1024×96 grid/footer). The marketing
mac-title-bar.pngnow comes only from the XCUITest full-window screenshot (top band crop). CI validation checks macOS traffic-light colors at the top-left, text density in the June 2026 nav band, and rejects bottom-heavy crops. Sidebar footer actions are grouped on the leading edge with refresh last, matching web #4638.Verify
VERDICT: INCOMPLETE(Linux sandbox; macOS capture is the gate)