Repository navigation
fix(macos): screencapture title bar with traffic-light validation - #4653
Closed
tyler-dane wants to merge 7 commits into
Closed
tyler-dane wants to merge 7 commits into
tyler-dane wants to merge 7 commits into
Conversation
Drop content compositing; crop XCUITest window screenshots only. Validate traffic lights, June nav text band, and reject footer/grid crops. Group sidebar footer icons on the leading edge per web #4638. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
added
the
agent-automerge
tyler-dane
marked this pull request as ready for review
October 20, 2026 23:07
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Contributor
Author
|
agent-loop: still conflicting after update-branch onto main. Closing so the issue can be relaunched. |
tyler-dane
removed
the
agent-automerge
13 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4331
Replaces #4651 (merge queue could not pick up CI fixes).
Summary
Uses
screencapture -lwith the parity window id for a real on-screen window PNG (traffic lights included), crops the top 120px band, and validates red/yellow/green lights in the top-left plus June nav text. Rejects bottom-of-window crops. Sidebar footer icons stay grouped on the leading edge.Verify
VERDICT: INCOMPLETE(macOS capture gate)