Repository navigation
fix(macos): command palette Phosphor icons for web parity - #4650
Merged
Merged
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
marked this pull request as ready for review
October 20, 2026 22:01
tyler-dane
added
the
agent-automerge
tyler-dane
enabled auto-merge
October 20, 2026 22:01
Drop content compositing; crop XCUITest window screenshots only. Validate traffic lights, June nav text band, and reject footer/grid crops. Group sidebar footer icons on the leading edge per web #4638. Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
13 tasks done
tyler-dane
added a commit
that referenced
this pull request
Oct 21, 2026
Capture mode removed .resizable to pin the 1280x820 window, which grays out the green zoom traffic light. The strict traffic-light check added in #4650 requires a colored green button, so the macOS capture job failed every run after it merged, and the title-bar reference showed a disabled button unlike the real window. minSize == maxSize already pins the window, so leave .resizable on. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4331
Summary
Renders command palette row icons with exported Phosphor glyphs (matching web) instead of SF Symbols, and opens the palette in parity capture with ⌘K like the web harness.
Verification
VERDICT: INCOMPLETE(Linux sandbox; macOS parity capture is the visual gate)Product notes
Icons without a Phosphor mapping (e.g. creditcard, globe) still fall back to SF Symbols until we extend the export set.