Repository navigation
fix(web): skip timed start date in event form tab order - #4504
Merged
Merged
Conversation
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
added
the
agent-automerge
Cursor
tyler-dane
marked this pull request as ready for review
October 16, 2026 16:27
tyler-dane
enabled auto-merge
October 16, 2026 16:27
Contributor
|
Boot bundle: 509.8 KB gzip (+0.0 KB vs main) |
This was referenced Oct 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4503
What and why
Adding the timed start-date picker introduced an extra Tab stop on the jump-target wrapper / date field before the start-time combobox. Timed events now skip the start date in Tab order (Title → Start time) while Mod+digit and programmatic field jumps still focus the date input. The jump wrapper stays
tabIndex={-1}so it cannot capture focus.Verify
Focused:
EventFormDateField.test.tsx,TimePickers.test.tsx(tab order).bun run verify --strict— VERDICT: FAIL ontest:webonly:guest-meet-cutover.test.ts>calendar-web production bundle > does not ship guest PublicBooking UI modulestimes out at 5000ms (production bundle build ~6.8s in this environment; file untouched by this diff). type-check, lint, knip, test:a11y, and test:e2e passed in the same run.