Repository navigation
fix(macos): preserve rich descriptions and add formatting controls - #4495
Merged
Merged
Conversation
…tests Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
Co-authored-by: Tyler Dane <tyler-dane@users.noreply.github.com>
tyler-dane
marked this pull request as ready for review
October 16, 2026 17:52
tyler-dane
enabled auto-merge
October 16, 2026 17:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4494
What and why
Native description edits flattened lists, reused the first matching line’s attributes, dropped nested emphasis inside links, and could crash on emoji because regex UTF-16 offsets were used as Swift character offsets. Preserve structured lists, soft breaks, blank paragraphs, unsupported HTML, and each line’s own formatting. Save bold, italic, and link changes immediately, including when no extra character is typed.
Add accessible Bold, Italic, Numbered list, and Bullet list controls with selection feedback, list continuation and renumbering, and read-only handling. Retain caret formatting across theme updates. Keyboard field jumps now scroll the requested form section into view. Normalize physical keypad Enter and character-only Enter events so Command+Enter saves from the rich-text editor.
The regression uses the real AppKit controls to format a note, save without further typing, reopen, and verify the text and Bold selection. Keep native keyboard-adapter tests in Xcode, and run 14 AppKit editor unit tests in the existing native package lane. Fixture launches skip real system notification prompts/delivery, and the title-typing fallback leaves real editors in control.
Verify
VERDICT: PASSThe reconciled head passes all strict checks: native Swift package tests, Xcode unit and interaction tests, type-check, lint, and knip. Swift contracts and desktop export checks pass. The native persistence regression exercises the actual toolbar and Command+Enter save path; Return/keypad normalization also has native adapter coverage.
The simplify pass removed duplicate inline-formatting conversion and the redundant test-only toolbar mirror/notification bridge. Named native checkbox queries exercise the actual toolbar directly. Preserve the remote button identifiers and deterministic Up Next test intent.