Repository navigation
fix(macos): confirm calendar account disconnection - #4506
Merged
Merged
Conversation
tyler-dane
marked this pull request as ready for review
October 16, 2026 23:33
tyler-dane
added
the
agent-automerge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4505
What and why
The native account row disconnected a calendar immediately, while web requires confirmation. Add inline Confirm and Cancel controls, move focus to Confirm and restore it on cancel, and keep busy/error handling on the existing disconnect path. A disappearing connection clears its pending confirmation.
Fixture launches reuse the notification isolation fix from #4495 so interaction tests do not request or deliver real system notifications. Keyboard interaction in Settings also depends on the scope fixes in #4499.
Verify
VERDICT: PASS
Full
bun run verify --strictpasses: Swift package tests, Xcode native tests, type-check, lint, and knip. CompassUI builds andgit diff --checkalso pass. Live provider disconnection has not been exercised; the API path itself is unchanged.