Repository navigation
Relax the type constraint of promote_rule only from method signature perspective - #366
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #366 +/- ##
==========================================
- Coverage 96.79% 96.69% -0.10%
==========================================
Files 7 7
Lines 812 818 +6
==========================================
+ Hits 786 791 +5
- Misses 26 27 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kimikage
force-pushed
the
relax_promote_rule_weak
branch
2 times, most recently
from
October 23, 2026 15:16
6aabb78 to
9e8589f
Compare
kimikage
marked this pull request as ready for review
October 23, 2026 15:25
kimikage
changed the title
promote_rule only from method signature perspectivepromote_rule only from method signature perspective
kimikage
marked this pull request as draft
October 23, 2026 22:49
kimikage
force-pushed
the
relax_promote_rule_weak
branch
4 times, most recently
from
October 24, 2026 01:39
cb76254 to
6650de7
Compare
kimikage
marked this pull request as ready for review
October 24, 2026 01:39
kimikage
force-pushed
the
relax_promote_rule_weak
branch
from
October 24, 2026 05:03
6650de7 to
7dfef8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a provisional substitute for PR #341.
This does not improve the results for non-concrete types, i.e., is "essentially" unrelated to Issue #343.
However, as a side effect, the upper bound
T <: Integerfor the raw type is introduced.This also adds a workaround for errors caused by the
Union{}.