Repository navigation
[WIP] Support for non-concrete types in promote_rule(::Type{<:FixedPoint}, ::Type{<:FixedPoint}) - #341
Draft
kimikage wants to merge 1 commit into
Draft
[WIP] Support for non-concrete types in promote_rule(::Type{<:FixedPoint}, ::Type{<:FixedPoint})#341kimikage wants to merge 1 commit into
promote_rule(::Type{<:FixedPoint}, ::Type{<:FixedPoint})#341kimikage wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #341 +/- ##
==========================================
+ Coverage 96.69% 96.71% +0.01%
==========================================
Files 7 7
Lines 818 821 +3
==========================================
+ Hits 791 794 +3
Misses 27 27 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
kimikage
marked this pull request as draft
September 29, 2026 07:40
kimikage
changed the title
promote_rule(::Type{<:FixedPoint}, ::Type{<:FixedPoint})promote_rule(::Type{<:FixedPoint}, ::Type{<:FixedPoint})
kimikage
force-pushed
the
relax_promote_rule
branch
2 times, most recently
from
October 17, 2026 10:10
7fd13d7 to
2d314e8
Compare
Collaborator
Author
|
Since this seems like it could turn into a lengthy discussion, I'll split the method signature changes and the actual promotion rule definitions into two separate PRs. Edit: Done (PR #366) |
… ::Type{<:FixedPoint})`
kimikage
force-pushed
the
relax_promote_rule
branch
from
October 25, 2026 04:29
2d314e8 to
9fe6bdd
Compare
kimikage
changed the title
promote_rule(::Type{<:FixedPoint}, ::Type{<:FixedPoint})promote_rule(::Type{<:FixedPoint}, ::Type{<:FixedPoint})
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I don't think this will help resolve the invalidation issue, but it will improve the consistency of our design policies.