Skip to content

fix: ARIA role structure in footer.ejs #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JinxiangChen22 merged 1 commit into from
May 9, 2026
Merged

fix: ARIA role structure in footer.ejs #5

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions views/partials/footer.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,9 @@

<div class="footer-left-column">
<p data-i18n="footer.desc">Join millions of people who organize work and life with Taskify.</p>
<ul role="list" aria-label="Social links">
<ul aria-label="Social links">

<li><a aria-label="facebook" href="#"><img src="../../static/assets/facebook.png" class="footer-image" alt="Facebook"></li>
<li><a aria-label="facebook" href="#"><img src="../../static/assets/facebook.png" class="footer-image" alt="Facebook"></a></li>
<li><a aria-label="youtube" href="#"><img src="../../static/assets/youtube.png" class="footer-image" alt="Youtube"></a></li>
<li><a aria-label="twitter" href="#"><img src="../../static/assets/twitter.png" class="footer-image" alt="Twitter"></a></li>
<li><a aria-label="instagram" href="#"><img src="../../static/assets/instagram.png" class="footer-image" alt="Instagram"></a></li>
Expand All @@ -30,7 +30,7 @@
<div class="footer-right-column">
<div class="footer-column">
<h3 class="footer-heading" data-i18n="footer.features">FEATURES</h3>
<ul aria-label="Footer" role="list">
<ul aria-label="Footer">

<li><a href="" data-i18n="footer.howItWorks">How It Works</a></li>
<li><a href="" data-i18n="footer.forTeams">For Teams</a></li>
Expand Down
Loading