fix: ARIA role structure in footer.ejs - #5
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked Issue
Closes: #issue number that will be closed through this PR
Describe the changes you've made
Fixed ARIA role structure violations reported by axe DevTools in footer.ejs :
Removed redundant role="list" from line 21 and line 33
elements already have implicit list role per HTML5 spec- Explicit role="list" requires all children to have role="listitem" , which
- does not inherit in this context
- This violates WCAG 2.1 SC 4.1.2 (Name, Role, Value)
Added missing closing tag on line 23
After these changes, axe DevTools no longer reports "Certain ARIA roles must contain particular children" errors on the homepage.