Repository navigation
refactor(link)!: move InARP into its own module - #2596
Merged
Merged
Conversation
- `InARP` moves from `pcapkit.protocols.link.arp` to the new `pcapkit.protocols.link.inarp`, with no re-export at the old path; `arp.py` keeps `ARP` alone and records `versionremoved:: 1.6.0`. - `pcapkit.protocols.link` imports `InARP` from its new home, so `pcapkit.InARP` and `pcapkit.protocols.InARP` are unchanged. - Docs: a new `inarp` page in the link toctree; the ARP page, `ext.rst`, the class-hierarchy click target, the TLS and link pages and protocol-family-grouping.rst point at the new path, and InARP leaves the page's list of classes still pending under #2529. - Tests: `test_inarp_unit.py` pins the new module, the bare old path and the top-level names; the #1744 ledger lists `arp.InARP` as removed and shipped; the ARP-family tests import from the new path.
JarryShaw
added
breaking
Owner
Author
|
GOOD TO GO at |
5 tasks done
Contributor
|
Coverage: 94.03% (unit tier, Python 3.15,
Per-file detail: the |
JarryShaw
removed
the
review: good-to-go
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…1.6.0 (#2449) - Added: DCCP, its checksum over the IP pseudo-header, register_dccp and register_dccp_option, and the pcapkit.const.dccp registries (#2593). - Folded into unreleased entries: LinuxSLL's stop on its ARPHRD path (#2587) and ARPHRD's __proto_dest__ (#2598), SSLv2 records chained in a segment (#2585), the checksum's move to pcapkit.corekit.checksum.internet (#2586), and IGMPv2's and IGMPv3's versioned name (#2590). - Breaking: InARP moves to pcapkit.protocols.link.inarp with no re-export, joining the DRARP entry (#2596). - Changed: the conventions' new rulings (#2599), the milestone workflow's next-open-milestone lookup (#2591), the PyPy protocols shards (#2604). Fixed: a handled next-layer refusal is quiet under beholder (#2597); the IPX crawlers restore sys.path (#2601). - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
This was referenced Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
refactor— changes neither behaviour nor performanceDescription of your pull request and other information
InARPmoves out ofpcapkit.protocols.link.arpinto its own module,pcapkit.protocols.link.inarp, following the one-protocol-class-per-module ruling on #2529, as the DRARP move (#2540) did. Its schema and data classes move with it.Breaking:
arp.InARPshipped in v1.5.1. It getsversionremoved:: 1.6.0and no re-export (#1715/#1744).pcapkit.InARPandpcapkit.protocols.InARPare unchanged. Dispatch imports, docs pages, cross-references and the #1744 ledger (SHIPPED/PURE) are retargeted. The rest of the issue's pending list is SSLv3 and NoPayload.Part of #2529