Repository navigation
refactor(application): move SSLv3 into its own module - #2602
Merged
Merged
Conversation
JarryShaw
added
refactor
Owner
Author
|
GOOD TO GO at |
Contributor
|
Coverage: 94.03% (unit tier, Python 3.15,
Per-file detail: the |
Owner
Author
|
resolve conflicts |
Owner
Author
This was referenced Nov 2, 2026
- SSLv3 moves from pcapkit.protocols.application.tls to the new pcapkit.protocols.application.sslv3, so tls holds TLS alone; no re-export at the old path. pcapkit.SSLv3, pcapkit.protocols.SSLv3 and pcapkit.protocols.application.SSLv3 are the moved class. - The application package imports SSLv3 from its new home. - New docs page sslv3.rst in the application toctree; tls.rst drops its SSLv3 autoclass; ssl.py, ssl.rst, tls.py, ext.rst and the hierarchy graph's click target point at the new path. - protocol-family-grouping.rst no longer lists tls.SSLv3 as pending. - tests/protocols/application/test_sslv3_unit.py pins the new home, that tls holds one protocol class, and SSLv3's parse and rebuild.
JarryShaw
force-pushed
the
refactor/2529-sslv3-module
branch
from
November 2, 2026 02:49
cfff299 to
d880a70
Compare
Owner
Author
|
Rebased onto
|
JarryShaw
removed
the
review: good-to-go
This was referenced Nov 2, 2026
Open
JarryShaw
added a commit
that referenced
this pull request
Nov 2, 2026
…s latest wave into 1.6.0 (#2449) - Added: every whole HTTP/2 frame in a TCP segment is a further HTTPv2 layer, the previous frame's payload, as with TLS (#2609). - Folded into unreleased entries: SSLv3 lives in pcapkit.protocols.application.sslv3 (#2602), and a reassembled DTLS Datagram's packet holds the deferred handshake decode (#2605). tls.SSLv3 is in no release tag, so the entry records no move. - Changed: the remaining xdist jobs at -n logical (#2606) join the CI entry, and the member-order entry cites the last reorder (#2613). - No entry for the test-only #2611 and #2612, or for #2610's private registry sentinel, which changes no behaviour. - CHANGELOG.md regenerated; util/changelog_md.py --check passes.
1 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make pylint,make mypy,make isort)make testpasses, and a test case covers the changeWhat is the purpose of your pull request?
refactor— changes neither behaviour nor performanceDescription of your pull request and other information
SSLv3moves out ofpcapkit.protocols.application.tlsinto its own module,pcapkit.protocols.application.sslv3, following the one-protocol-class-per-module ruling on #2529. The toctrees,ext.rstand the package exports are retargeted, and the #2529 pending list drops SSLv3.Not breaking:
tls.SSLv3was added after v1.5.1 and never shipped, so it gets noversionremoved, no ledger entry and no re-export. Once #2596 (InARP) merges, the pending list needs a one-line rebase here.Part of #2529