Repository navigation
ci(python): move the KTLO legs into jobs nothing gating waits on (#1738) - #1746
Merged
Merged
Conversation
- Owner's option A: the KTLO legs of `test`, `integration` and `pypcap-parity` are now `test-ktlo`, `integration-ktlo` and `pypcap-parity-ktlo` in unit-tests.yml. Neither `required-checks` nor `unittest-ordering` needs them, so a lost runner or the job cap on a KTLO leg no longer fails `Required checks passed`. - Each KTLO job runs its twin's steps by YAML alias, so the step-level `continue-on-error`, warning-level annotations and `KTLO summary` are unchanged; job-level `continue-on-error: true` is the backstop. - Check names are unchanged (`Python 3.x (KTLO)` and so on). - util/python_versions.py writes the three KTLO matrices; the gating matrices hold the supported tier only. - util/ci_timing.py resolves aliased steps and picks the most specific job name template; util/update_python_versions.py reports a leg moving between twins as a rename and counts the new jobs' legs. - workflows.rst and releasing.rst describe it; citations renumbered. Tests: test_ktlo_jobs_gate_nothing_1738.py pins the structure; the 1633, 1660, 1672, 1732, apt-cache and queue tests follow the move. Closes #1738
Owner
Author
|
Verdict: GOOD TO GO at
|
Contributor
|
Coverage: 89.69% (unit tier, Python 3.15,
Per-file detail: the |
3 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseCloses #1738. This implements the owner's option A.
test,integrationandpypcap-paritymove totest-ktlo,integration-ktloandpypcap-parity-ktlo. Neitherrequired-checksnorunittest-orderingneeds them, so a lost runner or a job-cap hit on a KTLO leg can no longer failRequired checks passed.continue-on-error, warning annotations andKTLO summaryare unchanged. Job-levelcontinue-on-error: trueis a backstop.python_versions.pyemits the KTLO matrices,ci_timing.pyfollows the aliased steps, andupdate_python_versions.pytreats a leg moving between twins as a rename. The docs are updated too.test_ktlo_jobs_gate_nothing_1738.py, plus updated 1633/1660/1672/1732 tests.pypcap-parityhas no supported leg.