Repository navigation
ci(python): the version updater flags a job its update would empty (#1747) - #1750
Merged
Merged
Conversation
…1747) Since #1746, `pypcap-parity` holds supported legs only, so 3.11 reaching end of life leaves it an empty matrix that `required-checks` still needs. Per the owner's ruling the updater retires nothing; it now names the job. - `emptied_jobs()` compares every script-read matrix before and after the tiers move; each job going from one leg or more to none becomes a `manual` note naming the job, the version moves that empty it, and the jobs whose `needs:` list it. - The plan carries them as `retire`; the body puts them first, in bold, before the ruleset edit, and not again under "Not done here". - The tier file is written as computed. The fingerprint stays the tiers alone, so retiring the job on `main` does not re-propose them. - workflows.rst's Python Versions section says so. Tests: test_python_versions_empty_job_1747 (5, each failing on main). Closes #1747
Owner
Author
|
Verdict: GOOD TO GO at
|
Contributor
|
Coverage: 89.57% (unit tier, Python 3.15,
Per-file detail: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please follow the guide below
You will be asked some questions, please read them carefully and answer honestly
Put an
xinto all the boxes [ ] relevant to your pull request (like that [x])Use Preview tab to see how your pull request will actually look like
Searched for similar pull requests
Followed the coding style (
make pylint,make mypy,make isort)make testpasses, and a test case covers the change. Narrow runs only, listed below.Added a changelog entry under
docs/source/changelog/and regeneratedCHANGELOG.md, if the change is user-visible: N/A — centralised in docs(changelog): shared 1.5.0 changelog — long-lived, merges last (#610, #616, #617, #618, #620) #657What is the purpose of your pull request?
Tick the commit type your subject line carries.
fix— corrects a defectfeat— adds a featureperf— changes performance, not behaviourrefactor— changes neither behaviour nor performancetest— tests onlydocs— documentation onlyci— workflows or build toolingrelease— bumps the version or rolls up a distributionchore— anything elseCloses #1747. Since #1746,
pypcap-parityholds only supported legs. Once 3.11 reaches end of life its matrix is empty, butrequired-checksstill needs it. Under the owner's ruling, the updater retires nothing itself; it flags the job instead.emptied_jobs()finds every matrix job the script reads that goes from at least one leg to none, KTLO twins andexperimental.ymlincluded. It emits amanualnote naming the job, the version moves that empty it, and the jobs thatneeds:it. Example: "pypcap-paritywould have no leg left once 3.11 moves to KTLO; retire or remove the job (and itsneeds:inrequired-checks) before merging this update."plan.json.maindoes not re-propose the update and recreate the branch.workflows.rstis updated.test_python_versions_empty_job_1747.py(5 tests, all failing onmain). The 1660, 1738, queue and doc-claims suites pass.